Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Increase tolerance for golden diffs on Safari #50655

Merged
merged 1 commit into from
Feb 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions web_sdk/web_test_utils/lib/image_compare.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,26 @@ Future<String> compareImage(
// comparison.
final int screenshotSize = screenshot.width * screenshot.height;

late int pixelColorDelta;
final int pixelColorDeltaPerChannel;
final double differentPixelsRate;

if (isCanvaskitTest) {
pixelColorDelta = 21;
differentPixelsRate = 0.1;
pixelColorDeltaPerChannel = 7;
} else if (skiaClient.dimensions != null && skiaClient.dimensions!['Browser'] == 'ios-safari') {
pixelColorDelta = 15;
differentPixelsRate = 0.15;
pixelColorDeltaPerChannel = 16;
} else {
pixelColorDelta = 3;
differentPixelsRate = 0.1;
pixelColorDeltaPerChannel = 1;
}

skiaClient.addImg(
filename,
screenshotFile,
screenshotSize: screenshotSize,
pixelColorDelta: pixelColorDelta,
differentPixelsRate: differentPixelsRate,
pixelColorDelta: pixelColorDeltaPerChannel * 3,
);
return 'OK';
}
Expand Down