This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Platform View Manager to Windows shell #50598
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #ifndef FLUTTER_SHELL_PLATFORM_WINDOWS_FLUTTER_WINDOWS_INTERNAL_H_ | ||
| #define FLUTTER_SHELL_PLATFORM_WINDOWS_FLUTTER_WINDOWS_INTERNAL_H_ | ||
|
|
||
| #include "flutter/shell/platform/windows/public/flutter_windows.h" | ||
|
|
||
| #if defined(__cplusplus) | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| // Declare functions that are currently in-progress and shall be exposed to the | ||
| // public facing API upon completion. | ||
|
|
||
| typedef int64_t PlatformViewId; | ||
|
|
||
| typedef struct { | ||
| size_t struct_size; | ||
| HWND parent_window; | ||
| const char* platform_view_type; | ||
| // user_data may hold any necessary additional information for creating a new | ||
| // platform view. For example, an instance of FlutterWindow. | ||
| void* user_data; | ||
| PlatformViewId platform_view_id; | ||
| } FlutterPlatformViewCreationParameters; | ||
|
|
||
| typedef HWND (*FlutterPlatformViewFactory)( | ||
| const FlutterPlatformViewCreationParameters*); | ||
|
|
||
| typedef struct { | ||
| size_t struct_size; | ||
| FlutterPlatformViewFactory factory; | ||
| void* user_data; // Arbitrary user data supplied to the creation struct. | ||
| } FlutterPlatformViewTypeEntry; | ||
|
|
||
| FLUTTER_EXPORT void FlutterDesktopEngineRegisterPlatformViewType( | ||
| FlutterDesktopEngineRef engine, | ||
| const char* view_type_name, | ||
| FlutterPlatformViewTypeEntry view_type); | ||
|
|
||
| #if defined(__cplusplus) | ||
| } | ||
| #endif | ||
|
|
||
| #endif // FLUTTER_SHELL_PLATFORM_WINDOWS_FLUTTER_WINDOWS_INTERNAL_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #include "flutter/shell/platform/windows/platform_view_manager.h" | ||
|
|
||
| #include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_method_codec.h" | ||
|
|
||
| namespace flutter { | ||
|
|
||
| namespace { | ||
| constexpr char kChannelName[] = "flutter/platform_views"; | ||
| constexpr char kCreateMethod[] = "create"; | ||
| constexpr char kFocusMethod[] = "focus"; | ||
| constexpr char kViewTypeParameter[] = "viewType"; | ||
| constexpr char kIdParameter[] = "id"; | ||
| constexpr char kDirectionParameter[] = "direction"; | ||
| constexpr char kFocusParameter[] = "focus"; | ||
| } // namespace | ||
|
|
||
| PlatformViewManager::PlatformViewManager(BinaryMessenger* binary_messenger) | ||
| : channel_(std::make_unique<MethodChannel<EncodableValue>>( | ||
| binary_messenger, | ||
| kChannelName, | ||
| &StandardMethodCodec::GetInstance())) { | ||
| channel_->SetMethodCallHandler( | ||
| [this](const MethodCall<EncodableValue>& call, | ||
| std::unique_ptr<MethodResult<EncodableValue>> result) { | ||
| const auto& args = std::get<EncodableMap>(*call.arguments()); | ||
| if (call.method_name() == kCreateMethod) { | ||
| const auto& type_itr = args.find(EncodableValue(kViewTypeParameter)); | ||
| const auto& id_itr = args.find(EncodableValue(kIdParameter)); | ||
| if (type_itr == args.end()) { | ||
| result->Error("AddPlatformView", "Parameter viewType is required"); | ||
| return; | ||
| } | ||
| if (id_itr == args.end()) { | ||
| result->Error("AddPlatformView", "Parameter id is required"); | ||
| return; | ||
| } | ||
| const auto& type = std::get<std::string>(type_itr->second); | ||
| const auto& id = std::get<std::int32_t>(id_itr->second); | ||
| if (AddPlatformView(id, type)) { | ||
| result->Success(); | ||
| } else { | ||
| result->Error("AddPlatformView", "Failed to add platform view"); | ||
| } | ||
| return; | ||
| } else if (call.method_name() == kFocusMethod) { | ||
| const auto& id_itr = args.find(EncodableValue(kIdParameter)); | ||
| const auto& direction_itr = | ||
| args.find(EncodableValue(kDirectionParameter)); | ||
| const auto& focus_itr = args.find(EncodableValue(kFocusParameter)); | ||
| if (id_itr == args.end()) { | ||
| result->Error("FocusPlatformView", "Parameter id is required"); | ||
| return; | ||
| } | ||
| if (direction_itr == args.end()) { | ||
| result->Error("FocusPlatformView", | ||
| "Parameter direction is required"); | ||
| return; | ||
| } | ||
| if (focus_itr == args.end()) { | ||
| result->Error("FocusPlatformView", "Parameter focus is required"); | ||
| return; | ||
| } | ||
| const auto& id = std::get<std::int32_t>(id_itr->second); | ||
| const auto& direction = std::get<std::int32_t>(direction_itr->second); | ||
| const auto& focus = std::get<bool>(focus_itr->second); | ||
| if (FocusPlatformView( | ||
| id, static_cast<FocusChangeDirection>(direction), focus)) { | ||
| result->Success(); | ||
| } else { | ||
| result->Error("FocusPlatformView", "Failed to focus platform view"); | ||
| } | ||
| return; | ||
| } | ||
| result->NotImplemented(); | ||
| }); | ||
loic-sharma marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| PlatformViewManager::~PlatformViewManager() {} | ||
|
|
||
| } // namespace flutter | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a permalink here. The line number will be wrong as the code continues to evolve