Revert "Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests" #50581
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
I don't understand why this is affecting goldens. The original PR did not. |
|
I'm seeing similar issues on other PRs (like on #50571). I'm wondering if the golden tests might be producing slightly different output across runs. |
…l/Transa…" This reverts commit a119a0d.
zanderso
force-pushed
the
revert-50540-swapchain
branch
from
94a63d1 to
f3d1a11
Compare
|
I've marked the fix forward as autosubmit. i'll restart the roller once that lands |
This is a fix forward alternative to the revert here: #50581 If the revert lands first I'll rebase into this. I'm working on verifying this locally against the devicelab tests.
|
Fix forward is looking good |
Reverts #50540
There's something wrong with this on armeabi_v7a API 24 devices like the moto g4s in the lab.
Will let us restart the roll (flutter/flutter#143342)