Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Don't suppress outdated validation error. #50568

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[Impeller] Don't suppress outdated validation error. #50568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions impeller/renderer/backend/vulkan/debug_report_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
return Result::kContinue;
}

// Issue in older versions of the SDK.
// https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/3554
if (data->pMessageIdName != nullptr &&
strstr(data->pMessageIdName, "CoreValidation-Shader-OutputNotConsumed") !=
nullptr) {
return Result::kContinue;
}

// This is a real error but we can't fix it due to our headers being too
// old. More more details see:
// https://vulkan.lunarg.com/doc/view/1.3.224.1/mac/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-imageViewFormatSwizzle-04465
Expand Down