This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[web] Fix Scene clip bounds. Trigger resize on DPR Change." #50457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Feb 8, 2024
| // Must be the true DPR from the browser, nothing overridable. | ||
| // See: https://github.com/flutter/flutter/issues/143124 | ||
| final double browserDpr = EngineFlutterDisplay.instance.browserDevicePixelRatio; | ||
| // The scene clip is the size of the entire window **in Logical pixels**. |
|
Trying again, see if this time this one sticks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 9, 2024
…143195) flutter/engine@95feed1...7b579dc 2024-02-08 ditman@gmail.com Reland "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50457) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Testing
Goldens
Verified locally that all the golden tests that caused this to roll back looked acceptable:
Test app
Next steps
During the investigation of this rollback, we found some opportunities to improve our web tests in the repo. Tracking issue:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.