Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Skip flaking test on Windows nobody is fixing. #50401

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Skip flaking test on Windows nobody is fixing. #50401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94b72c9
Skip flaking test on Windows nobody is fixing.
matanlurey Feb 6, 2024
5e73265
Add skip to testWithSemantics.
matanlurey Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/web_ui/test/engine/pointer_binding_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,8 +2620,9 @@ void _testClickDebouncer({required PointerBinding Function() getBinding}) {

void testWithSemantics(
String description,
Future<void> Function() body,
) {
Future<void> Function() body, {
Object? skip,
}) {
test(
description,
() async {
Expand All @@ -2631,6 +2632,7 @@ void _testClickDebouncer({required PointerBinding Function() getBinding}) {
await body();
EngineSemantics.instance.semanticsEnabled = false;
},
skip: skip,
);
}

Expand Down Expand Up @@ -2913,8 +2915,8 @@ void _testClickDebouncer({required PointerBinding Function() getBinding}) {
semanticsActions,
isEmpty,
);
});

// TODO(yjbanov): https://github.com/flutter/flutter/issues/142991.
}, skip: operatingSystem == OperatingSystem.windows);

testWithSemantics('Forwards click if enough time passed after the last flushed pointerup', () async {
expect(EnginePlatformDispatcher.instance.semanticsEnabled, true);
Expand Down