This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] added mipmaps to subpasses directly on a draw call #50157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
approved these changes
Jan 30, 2024
gaaclarke
force-pushed
the
blur-mips-on-draw
branch
from
c47567a to
bcfb61c
Compare
gaaclarke
added
the
autosubmit
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
removed
the
autosubmit
gaaclarke
force-pushed
the
blur-mips-on-draw
branch
from
bcfb61c to
2d80775
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 30, 2024
…142548) flutter/engine@0e4342c...cd12316 2024-01-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179) 2024-01-30 30870216+gaaclarke@users.noreply.github.com [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157) 2024-01-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172) 2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175) 2024-01-30 jonahwilliams@google.com [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122) 2024-01-30 mk12360@gmail.com Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#142001
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.