This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds #50058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiehe-google-com
changed the title
zijiehe-google-com
force-pushed
the
main
branch
from
2ebe9fd to
1432e6d
Compare
| from typing import List | ||
|
|
||
| # The import is coming from vpython wheel and pylint cannot find it. | ||
| import yaml # pylint: disable=import-error |
There was a problem hiding this comment.
@dnfield do you know how we would go about adding yaml to the engine deps?
There was a problem hiding this comment.
CaseyHillers
approved these changes
Jan 30, 2024
zijiehe-google-com
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2024
…aml on debug and release builds (flutter/engine#50058)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2024
…142587) flutter/engine@8e7df85...447dd21 2024-01-31 skia-flutter-autoroll@skia.org Roll Skia from 1fbb575f968d to fec9deb3d8c6 (1 revision) (flutter/engine#50192) 2024-01-31 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds (flutter/engine#50058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Feb 2, 2024
…l on debug and release builds" (#50291) Reverts #50058 for flutter/flutter#142811
8 tasks
zijiehe-google-com
added a commit
that referenced
this pull request
Feb 7, 2024
…on debug and release builds" (#50408) Reverts #50407, flutter/flutter#142811, redo #50058. Comparing to the original change, this redo disabled lto / link time optimization for x64 release builder. It's a known issue that lto increased the compilation time from <5 min to over 30 min. (See commit a1b104c.) Disabling lto is safe on x64 release since fuchsia assembly uses arm64 release build on smart display instead. But I will send a PSA to the fuchsia team before submitting this change. Following is the original change description. This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner. - Tests with packages out of out/fuchsia_*_x64/ are ignored for now. - Tests with extra test command line parameters are ignored for now. The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel. This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well. - Tests not built with AOT are filtered out with variant field in test_suites.yaml. Bug: flutter/flutter#140179 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a BundledTestRunner to run most of the tests in testing/fuchsia/test_suites.yaml as ExecutableTestRunner.
The BundledTestRunner can share most of the logic in ExecutableTestRunner and avoid reinventing the wheel.
This change also fixes the build break of fuchsia_tests in fuchsia_release_x64 which allows tests to run on the build as well.
Bug: flutter/flutter#140179
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.