[Impeller] Assign incremental clip depth to all entities. #49828

bdero · 2024-01-17T10:35:10Z

Add depth settings to pipeline variant hash.
Assign new clip depth to all entities.
Punt the final depth to all the vertex shaders.
Add validations to assert all clip depths are resolved.

bdero · 2024-01-31T23:00:15Z

This gets us as close to switching clips to the depth buffer as possible without actually doing it. I want to keep the diff to flip it on minimal so that we can easily revert it if there are problems.

flutter-dashboard · 2024-01-31T23:50:52Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #49828 at sha 3104b26

bdero · 2024-02-01T00:05:20Z

Got some weird stuff going on with the goldens again. Looking into it.

bdero · 2024-02-01T00:23:26Z

nvm, accidentally changed the compare op, so this should be fixed.

jonahwilliams

LGTM

For my understanding, this adjusts the depth but we're still clipping via stencil ops, right?

jonahwilliams · 2024-02-01T00:47:51Z

impeller/entity/entity.cc

+  return new_clip_depth_;
+}
+
+static Scalar depth_epsilon = 1.0f / std::pow(2, 18);


constexpr? or at least const

jonahwilliams · 2024-02-01T00:49:58Z

impeller/entity/entity_playground.cc

@@ -30,6 +30,8 @@ bool EntityPlayground::OpenPlaygroundHere(EntityPass& entity_pass) {
    return false;
  }

+  entity_pass.PopAllClips(1000);


Added a comment to explain why we need to do this in the Entity playground specifically.

jonahwilliams · 2024-02-01T00:53:25Z

impeller/renderer/backend/gles/texture_gles.cc

@@ -154,12 +154,12 @@ struct TexImage2DData {
        // only use the stencil component.
        //
        // https://registry.khronos.org/OpenGL-Refpages/gl4/html/glTexImage2D.xhtml
+      case PixelFormat::kD24UnormS8Uint:


hmm, should we have been hitting this path before?

I don't think we ever hit this path if offscreen MSAA is supported.

flutter-dashboard · 2024-02-01T02:20:50Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #49828 at sha 68e0b12

bdero · 2024-02-01T05:40:43Z

For my understanding, this adjusts the depth but we're still clipping via stencil ops, right?

Yeah, it gets the correct depth values pumping into clip space but doesn't actually use them yet.

…lutter/engine#49828)

…142726) flutter/engine@68943af...8c43332 2024-02-01 zanderso@users.noreply.github.com Moves impeller/golden_tests_harvester to tools/golden_tests_harvester (flutter/engine#50211) 2024-02-01 skia-flutter-autoroll@skia.org Roll Skia from 2386d5077ec5 to cdf214adfb4d (2 revisions) (flutter/engine#50239) 2024-02-01 skia-flutter-autoroll@skia.org Roll Skia from 20578fecfc37 to 2386d5077ec5 (2 revisions) (flutter/engine#50238) 2024-02-01 skia-flutter-autoroll@skia.org Roll Skia from 756276a133b1 to 20578fecfc37 (1 revision) (flutter/engine#50236) 2024-02-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nymRxHV9Shod7cyLe... to kvEXgoydRYnW3UvX2... (flutter/engine#50235) 2024-02-01 bdero@google.com [Impeller] Assign incremental clip depth to all entities. (flutter/engine#49828) 2024-02-01 skia-flutter-autoroll@skia.org Roll Skia from 505d22d0ecdc to 756276a133b1 (3 revisions) (flutter/engine#50232) 2024-02-01 skia-flutter-autoroll@skia.org Roll Skia from bcbc172f74da to 505d22d0ecdc (1 revision) (flutter/engine#50230) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from nymRxHV9Shod to kvEXgoydRYnW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Depends on #49828. No semantic change. Also adds/documents stencil configurations that are needed for StC. Operations for the current stencil stack are labeled as "legacy".

bdero self-assigned this Jan 17, 2024

github-actions bot added the e: impeller label Jan 17, 2024

bdero force-pushed the bdero/depth-settings branch from 146d0c6 to 59469d2 Compare January 17, 2024 10:35

bdero mentioned this pull request Jan 17, 2024

[Impeller] Switch from transient stencil-only to depth+stencil buffer. #47987

Merged

bdero force-pushed the bdero/depth-settings branch from 59469d2 to a8d3369 Compare January 22, 2024 23:15

bdero force-pushed the bdero/depth-settings branch from a8d3369 to 7197858 Compare January 30, 2024 03:45

bdero changed the title ~~[Impeller] Add depth settings to pipeline variant hash.~~ [Impeller] Assign incremental clip depth to all entities. Jan 30, 2024

bdero force-pushed the bdero/depth-settings branch 3 times, most recently from 07473a6 to c7c73c9 Compare January 30, 2024 23:16

bdero marked this pull request as ready for review January 31, 2024 22:57

bdero requested a review from jonahwilliams January 31, 2024 22:57

flutter-dashboard bot added the will affect goldens label Jan 31, 2024

bdero removed the request for review from jonahwilliams February 1, 2024 00:06

bdero requested review from jonahwilliams and chinmaygarde February 1, 2024 00:23

jonahwilliams approved these changes Feb 1, 2024

View reviewed changes

[Impeller] Add depth settings to pipeline variant hash.

af24113

bdero force-pushed the bdero/depth-settings branch from 9f68ae8 to af24113 Compare February 1, 2024 04:53

bdero mentioned this pull request Feb 1, 2024

[Impeller] Replace stencil pipeline ops with enum. #50231

Merged

bdero merged commit c3a7f59 into flutter:main Feb 1, 2024

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to c3a7f5995be8 (3 revisions) flutter/flutter#142702

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

d361aab

…lutter/engine#49828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to 3038224c7aba (4 revisions) flutter/flutter#142704

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

8672bba

…lutter/engine#49828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to d5017b33ef08 (5 revisions) flutter/flutter#142707

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

796f0ca

…lutter/engine#49828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to d5017b33ef08 (5 revisions) flutter/flutter#142719

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

8b3c0fd

…lutter/engine#49828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to a1205d3300fb (6 revisions) flutter/flutter#142722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

b4534d8

…lutter/engine#49828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) flutter/flutter#142726

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

c3a7f5995 [Impeller] Assign incremental clip depth to all entities. (f…

0551485

…lutter/engine#49828)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Assign incremental clip depth to all entities. #49828

[Impeller] Assign incremental clip depth to all entities. #49828

Uh oh!

bdero commented Jan 17, 2024 •

edited

Loading

Uh oh!

bdero commented Jan 31, 2024

Uh oh!

flutter-dashboard bot commented Jan 31, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

jonahwilliams Feb 1, 2024

Uh oh!

bdero Feb 1, 2024

Uh oh!

jonahwilliams Feb 1, 2024

Uh oh!

bdero Feb 1, 2024

Uh oh!

jonahwilliams Feb 1, 2024

Uh oh!

bdero Feb 1, 2024

Uh oh!

flutter-dashboard bot commented Feb 1, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

Uh oh!

[Impeller] Assign incremental clip depth to all entities. #49828

[Impeller] Assign incremental clip depth to all entities. #49828

Uh oh!

Conversation

bdero commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdero commented Jan 31, 2024

Uh oh!

flutter-dashboard bot commented Jan 31, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

bdero Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

bdero Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

bdero Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Feb 1, 2024

Uh oh!

bdero commented Feb 1, 2024

Uh oh!

Uh oh!

bdero commented Jan 17, 2024 •

edited

Loading