This repository was archived by the owner on Feb 25, 2025. It is now read-only.
When building clang-tidy commands, filter out the sed command that may be appended to each compile command #49605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Jan 8, 2024
| @@ -57,6 +57,7 @@ class Command { | |||
|
|
|||
| static final RegExp _pathRegex = RegExp(r'\S*clang/bin/clang'); | |||
| static final RegExp _argRegex = RegExp(r'-MF \S*'); | |||
| static final RegExp _sedRegex = RegExp(r'&& sed.*$'); | |||
There was a problem hiding this comment.
I wonder if this shouldn't just filter out anything following the first &&?
jason-simmons
force-pushed
the
clang_tidy_filter_sed
branch
from
ad229b6 to
c4d1300
Compare
…y be appended to each compile command See flutter#49542
jason-simmons
force-pushed
the
clang_tidy_filter_sed
branch
from
c4d1300 to
1db054b
Compare
zanderso
approved these changes
Jan 8, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2024
…nd that may be appended to each compile command (flutter/engine#49605)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2024
…141144) flutter/engine@ee1ded6...09a74a0 2024-01-08 jason-simmons@users.noreply.github.com When building clang-tidy commands, filter out the sed command that may be appended to each compile command (flutter/engine#49605) 2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from af845097acae to 5497d5a53ae2 (6 revisions) (flutter/engine#49606) 2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from a0aba842460c to af845097acae (3 revisions) (flutter/engine#49601) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49542