This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Multiview pipeline Pt. 2: Split out EndFrame #49341
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a series of changes to reland #47239, following #49266. All changes included in this PR are exactly the same as they were in the original PR #47239.
This PR is a refactor that splits out the per-frame operations of
Animator
at the end ofRender
andBeginFrame
to a separate function,EndFrame
, which is executed right afterRender
.This PR is expected to increase the build time, because more code is now run before
frame_timings_recorder_->RecordBuildEnd
:RecordBuildEnd
:Render
call must now return to Dart, then toAnimator::BeginFrame
, beforeRecordBuildEnd
inEndFrame
. The two extra context switches are included in the build time.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.