Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux] Remove the usage of std::function in FlKeyEmbedderResponder #49293

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

dkwingsmt
Copy link
Contributor

Fixes flutter/flutter#140183

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing -- just one nit on implementation.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
@auto-submit auto-submit bot merged commit fb4fe26 into flutter:main Jan 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2024
…141496)

flutter/engine@205ed68...b06478b

2024-01-12 dnfield@google.com [Impeller] Properly size struct emplacements for Vulkan Runtime Effects (flutter/engine#49768)
2024-01-12 zanderso@users.noreply.github.com Fix linux_android_emulator_api_33 build config for rbe (flutter/engine#49776)
2024-01-12 dkwingsmt@users.noreply.github.com [Linux] Remove the usage of std::function in FlKeyEmbedderResponder (flutter/engine#49293)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux/GTK embedder is placing C++ std::function instances within GTK objects
2 participants