This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Unpin mac_toolchain version #48994
Merged
Unpin mac_toolchain version #48994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
vashworth
added
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
…140180) flutter/engine@0e7248d...0b0fab8 2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…isions)" (#140194) Reverts #140180 Initiated by: zanderso This change reverts the following previous change: Original Description: flutter/engine@0e7248d...0b0fab8 2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…140195) flutter/engine@0e7248d...4cb3ba7 2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069) 2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065) 2023-12-15 dnfield@google.com [Impeller] impellerc: delete unused code (flutter/engine#49061) 2023-12-15 30870216+gaaclarke@users.noreply.github.com [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050) 2023-12-15 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] Turned on new blur." (flutter/engine#49062) 2023-12-14 matanlurey@users.noreply.github.com Fix header-guard naming convention in `shell/`. (flutter/engine#49006) 2023-12-14 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054) 2023-12-14 matanlurey@users.noreply.github.com Rename `font-subset` to `font_subset`. (flutter/engine#49051) 2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056) 2023-12-14 chingjun@google.com Suppress warning for the new Activity library. (flutter/engine#49046) 2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac_toolchain has been updated to no longer have 2 minute slowdown (flutter/flutter#138109), so unpin to use the latest version.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.