This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Android] Check for text to paste before trying to retrieve data from URI #48166
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
edb08a5
Add fix
camsim99 5f69541
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 35a71a0
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 99bdb12
Re-add text check
camsim99 29bfca2
Formatting
camsim99 b2a514a
Add branching to clipboard logic
camsim99 f26c5b3
Working on tests
camsim99 165fc05
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 3f84b32
modify code, add tests
camsim99 2df7f8c
Formatting
camsim99 bf8bf57
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 a339df3
Reduce branching, reorganize tests
camsim99 d1343b1
Extract URI logic
camsim99 b7aa9d3
Reduce redundant setup in test
camsim99 72d5f30
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 483ea4d
Undo overkill
camsim99 8d93d73
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 190c9ad
fix merge
camsim99 b508241
Merge remote-tracking branch 'upstream/main' into paste_bug
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nonblocking nit: consider extracting uri logic into a method or methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved logic trying to extract text from URI to a new method!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undid this due to some recent changes here that actually made the new method more confusing.