This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make fml/... compatible with .clang-tidy.
#48150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added
the
test: all
cyanglaz
approved these changes
Nov 17, 2023
cbracken
reviewed
Nov 17, 2023
cyanglaz
suggested changes
Nov 17, 2023
fml/platform/darwin/weak_nsobject.h
Outdated
| : WeakNSProtocol<id>(container, checker) {} | ||
| explicit WeakNSObject(RefPtr<fml::WeakContainer> container, | ||
| const debug::DebugThreadChecker& checker) | ||
| : WeakNSProtocol<id>(std::move(container), checker) {} |
There was a problem hiding this comment.
Actually, I didnt catch this first time going through. We should not move here as the factory might spawn multiple weak pointers. Same above for the weak_ptr.
There was a problem hiding this comment.
Agreed, changing to reference.
matanlurey
added
the
autosubmit
|
I just landed 1427b9c, which is related. Just to be sure, could you rebase to get those changes and re-run the CI? |
Sure, done. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2023
…138647) flutter/engine@e010f17...c38272b 2023-11-17 matanlurey@users.noreply.github.com Make `fml/...` compatible with `.clang-tidy`. (flutter/engine#48150) 2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 03cddb5d740d to 3d4886a2e218 (1 revision) (flutter/engine#48187) 2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from dd7a26ead897 to 04b0ac194443 (8 revisions) (flutter/engine#48186) 2023-11-17 jhy03261997@gmail.com [Android] Send " did gain focus" message from engine to framework (flutter/engine#47114) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.