This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Migrate unit tests to named Rect factories #47430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2023
…137635) flutter/engine@4da3e5b...39be0fc 2023-10-31 matanlurey@users.noreply.github.com [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495) 2023-10-31 flar@google.com [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430) 2023-10-31 khalidcomilla58@gmail.com [Typo fixed] in DEPS (flutter/engine#47440) 2023-10-31 jonahwilliams@google.com [Impeller] Restore GLES GPU query times. (flutter/engine#47511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Oct 31, 2023
…lutter#137635) flutter/engine@4da3e5b...39be0fc 2023-10-31 matanlurey@users.noreply.github.com [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495) 2023-10-31 flar@google.com [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430) 2023-10-31 khalidcomilla58@gmail.com [Typo fixed] in DEPS (flutter/engine#47440) 2023-10-31 jonahwilliams@google.com [Impeller] Restore GLES GPU query times. (flutter/engine#47511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite step to deleting the un-named Constructors for Rect and moving to named factories. The intention is both to improve code readability and so that the underlying storage information is not implied or exposed.
This PR only modifies the unit tests which will not affect actual running apps, but migrates >95% of the concrete Rect construction to the named factory methods. Use of these constructors in the rest of the code is very rare since most methods get their Rect instances from data they compute or are delivered from elsewhere. Those other instances will be eliminated more on a file by file basis to reduce the surface area of errors arising due to typos or porting mistakes.