This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Rename blobcat to shader_archive(r). #47247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather confusingly, shader library were named after the tool that concatenated shader blobs. This changes the name to be less confusing. In the future, I am reworking this to create libraries for multiple backends.
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2023
…137127) flutter/engine@3dd197d...71600d8 2023-10-24 chinmaygarde@google.com [Impeller] Rename blobcat to shader_archive(r). (flutter/engine#47247) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
added a commit
to bdero/impeller-cmake
that referenced
this pull request
Nov 1, 2023
Fixes breakages from: * flutter/engine#47080 * flutter/engine#47247 * flutter/engine#47278
bdero
added a commit
to bdero/impeller-cmake
that referenced
this pull request
Nov 1, 2023
Fixes breakages from: * flutter/engine#47080 * flutter/engine#47247 * flutter/engine#47278
bdero
added a commit
to bdero/impeller-cmake
that referenced
this pull request
Nov 1, 2023
Fixes breakages from: * flutter/engine#47080 * flutter/engine#47247 * flutter/engine#47278
bdero
added a commit
that referenced
this pull request
Nov 1, 2023
bdero/impeller-cmake#20 Fixes breakages from: * #47080 * #47247 * #47278
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather confusingly, shader library were named after the tool that concatenated shader blobs. This changes the name to be less confusing. In the future, I am reworking this to create libraries for multiple backends.
No functional change. I just changed the names of classes and variables.