This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing import #47083
Merged
Add missing import #47083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following: flutter@6b262a0 results in the following error appearing internally when compiling for Android: ``` In file included from fml/synchronization/sync_switch.cc:5: ./fml/synchronization/sync_switch.h:74:34: error: implicit instantiation of undefined template 'std::vector<fml::SyncSwitch::Observer *>' mutable std::vector<Observer*> observers_; ^ <...>: note: template is declared here class _LIBCPP_TEMPLATE_VIS vector; ^ 1 error generated. ```
CaseyHillers
approved these changes
Oct 19, 2023
Member
Author
|
Aaron, would you like to take a look here too? Not sure why it doesn't fail for the build here though. |
gaaclarke
approved these changes
Oct 19, 2023
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm! sorry for the delay, i was ooo
CaseyHillers
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2023
…136910) flutter/engine@9d49175...bfd2ffb 2023-10-19 ychris@google.com [iOS] Load additional Cupertino system fonts (flutter/engine#46857) 2023-10-19 jiahaog@users.noreply.github.com Add missing import (flutter/engine#47083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Fixes the following: 6b262a0 results in the following error appearing internally when compiling for Android: ``` In file included from fml/synchronization/sync_switch.cc:5: ./fml/synchronization/sync_switch.h:74:34: error: implicit instantiation of undefined template 'std::vector<fml::SyncSwitch::Observer *>' mutable std::vector<Observer*> observers_; ^ <...>: note: template is declared here class _LIBCPP_TEMPLATE_VIS vector; ^ 1 error generated. ``` *List which issues are fixed by this PR. You must list at least one issue.* b/306266542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
6b262a0 results in the following error appearing internally when compiling for Android:
List which issues are fixed by this PR. You must list at least one issue.
b/306266542
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.