[Impeller] Skia gold for flutter_tester dart tests. #47066
Conversation
|
(rather than trying to use Platform.script, I'm adding a dart define for a skia gold working directory) |
chinmaygarde
changed the title
|
There's a few things that need to be fixed still:
|
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
dnfield
added
the
autosubmit
testing/run_tests.py
Outdated
| # | ||
| # See: https://bugs.python.org/issue26903 | ||
| max_processes = multiprocessing.cpu_count() | ||
| max_processes = 1 # multiprocessing.cpu_count() |
There was a problem hiding this comment.
No, I'll revert this. This was to try to isolate an issue on ci.
| return imageBytes; | ||
| } | ||
|
|
||
| String _getEngineCheckoutPath() { |
There was a problem hiding this comment.
Can you compute this using this.workDirectory and the Engine.findWithin constructor in https://github.com/flutter/engine/blob/main/tools/pkg/engine_repo_tools/lib/engine_repo_tools.dart#L87.
There was a problem hiding this comment.
TIL, yes this should work nicely. Trying it.
|
Removing |
zanderso
removed
autosubmit
|
Golden file changes are available for triage from new commit, Click here to view. |
dnfield
added
autosubmit
…137789) flutter/engine@b11e318...1e2eee0 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610) 2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606) 2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611) 2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
5 participants
This removes skips for the golden tests in
//testing/dart/canvas_test.dartand instead passes them up to Skia gold.Adds a utility class for dealing with Skia gold from these tests, as well as the existing fuzzy identical image comparison for tests that just want to do in memory comparison of images generated from the same test.
Removes the old golden files that were in tree.
Part of flutter/flutter#53784