Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use x86 machines for ios builds. #46726

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Use x86 machines for ios builds. #46726

merged 3 commits into from
Oct 10, 2023

Conversation

godofredoc
Copy link
Contributor

This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use x86 machines for ios builds.
85174dc 
This is to workaround rosetta not being installed in dart-internal
machines and to unblock beta releases.

Bug: flutter/flutter#136219
@zanderso
Copy link
Member

What is the plan for getting Rosetta onto the release builders?

zanderso
zanderso approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to help get the release out, but I would like to know what the plan is for making the all of the CI environments consistent with each other.

ci/builders/mac_ios_engine.json
@@ -4,7 +4,8 @@
"drone_dimensions": [
"device_type=none",
"mac_model=Macmini8,1",
"os=Mac-12"
"os=Mac-12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these have "mac_model=Macmini8,1" and some don't. Is that important?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point mac_model=Macmini8,1 will resolve to x86. Removing them for consistency.

@godofredoc
Copy link
Contributor Author

Macmini8

LGTM to help get the release out, but I would like to know what the plan is for making the all of the CI environments consistent with each other.

It is unlikely we'll be able to enable rosetta on dart-internal machines. Opened #46697 to run some validations and it seems like the only blocker is gen_snapshot expected to be x64, I'll talk to @cbracken about potential solutions.

@zanderso
Copy link
Member

It is unlikely we'll be able to enable rosetta on dart-internal machines.

Could you explain why this is? I think it is very important that the release builder environment and the prod/staging/try environments are consistent with each other, or we are going to have some very confusing issues come up only when we are doing release builds.

@godofredoc
Copy link
Contributor Author

It is unlikely we'll be able to enable rosetta on dart-internal machines.

Could you explain why this is? I think it is very important that the release builder environment and the prod/staging/try environments are consistent with each other, or we are going to have some very confusing issues come up only when we are doing release builds.

Internal macs are provisioned with additional restrictions to comply with higher security requirements and the provisioning process is standardized for all the teams.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit auto-submit bot merged commit b64b976 into flutter:main Oct 10, 2023
@zanderso
Copy link
Member

Internal macs are provisioned with additional restrictions to comply with higher security requirements and the provisioning process is standardized for all the teams.

Could you please clarify what is the specific security requirement that makes it impossible to have Rosetta installed on these machines?

XilaiZhang pushed a commit to XilaiZhang/engine that referenced this pull request Oct 10, 2023
@godofredoc @XilaiZhang
Use x86 machines for ios builds. (flutter#46726)
6fe97ad 
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
b64b97614 Use x86 machines for ios builds. (flutter/engine#46726)
43e7196
XilaiZhang added a commit that referenced this pull request Oct 10, 2023
@XilaiZhang @godofredoc
[flutter release cp] Use x86 machines for ios builds. (#46726) (#46737)
7ccdde7 
This is to workaround rosetta not being installed in dart-internal
machines and to unblock beta releases.

Bug: flutter/flutter#136219

Co-authored-by: godofredoc <godofredoc@google.com>
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 702f366b1c5d to bdeb53455f7c (6 revisions) (#…
640050b 
…136292)

flutter/engine@702f366...bdeb534

2023-10-10 john@johnmccutchan.com Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724)
2023-10-10 matanlurey@users.noreply.github.com Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729)
2023-10-10 godofredoc@google.com Use x86 machines for ios builds. (flutter/engine#46726)
2023-10-10 chinmaygarde@google.com Remove workaround for older versions of MSVC. (flutter/engine#46689)
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728)
2023-10-10 jonahwilliams@google.com [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@cbracken
Copy link
Member

Just wanted to follow up on @zanderso's question as to what security concerns we have with Rosetta. Is there some documentation covering the rationale?

CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Oct 16, 2023
@godofredoc
Use x86 machines for ios builds. (flutter#46726)
096ecb7 
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Oct 16, 2023
@godofredoc
Use x86 machines for ios builds. (flutter#46726)
4f04f17 
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
CaseyHillers pushed a commit that referenced this pull request Oct 16, 2023
@godofredoc
[CP] Use x86 machines for ios builds (#46726) (#46955)
e414f6a 
Fix issue with x86 ios builds failing due to wrong arch specified in
swarming

b/305605364

Co-authored-by: godofredoc <godofredoc@google.com>
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@godofredoc @harryterkelsen
Use x86 machines for ios builds. (#46726)
9c2ff34 
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc godofredoc deleted the use_x64_ios branch January 12, 2024 19:46
@ryanaltair ryanaltair mentioned this pull request Apr 2, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@godofredoc @zanderso @cbracken @XilaiZhang