This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Multi-view View Metrics #46174
Merged
Multi-view View Metrics #46174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: desktop
platform-macos
platform-linux
platform-windows
labels
5 tasks
|
(triage) @dkwingsmt said last week that he will come back to this PR soon. |
|
Yes, I'll finish this once #46213 is merged, since they share the same structure and embedder API changes. |
55 tasks
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
reviewed
Mar 12, 2024
loic-sharma
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Nice! LGTM but please get approval from @cbracken or @chinmaygarde for the embedder.h ABI
cbracken
reviewed
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2024
…145123) flutter/engine@6710d10...599dbd7 2024-03-14 737941+loic-sharma@users.noreply.github.com [Embedder API] Add multi-view present callback (flutter/engine#51267) 2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from a315e4572f4e to cac09f152d9b (10 revisions) (flutter/engine#51398) 2024-03-14 dkwingsmt@users.noreply.github.com Multi-view View Metrics (flutter/engine#46174) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
FlutterWindowMetricsEvent.viewIdto the embedder API.This PR only tests the ability to send metrics event for the implicit view. Once multiple views can be added via embedder API, we should test the ability to send different IDs.
Part of flutter/flutter#144806
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.