This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not run real processes in clang_tidy_test.dart
#45748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
changed the title
clang_tidy_test.dart
zanderso
reviewed
Sep 13, 2023
| @@ -0,0 +1,117 @@ | |||
| // Copyright 2013 The Flutter Authors. All rights reserved. | |||
Member
There was a problem hiding this comment.
I don't see an implementation of something like this anywhere else in the engine repo. At some point, I'd guess that we'll want to pull this out to its own package in the engine repo to share among other packages, or upstream something like https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/src/fake_process_manager.dart to https://github.com/google/process.dart
Contributor
Author
There was a problem hiding this comment.
Yeah I agree with that! I'd probably say:
- Pull this into
tools/pkg/fake_process_manageras soon as we need it somewhere else. - Chat with Chris about moving
flutter_tools' implementation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 13, 2023
…134676) flutter/engine@5e671d5...b71b366 2023-09-13 matanlurey@users.noreply.github.com Do not run real processes in `clang_tidy_test.dart` (flutter/engine#45748) 2023-09-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds test to verify wide gamut indexed png decompression fix for Skia. (flutter/engine#45399) 2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 284c333d7eb2 to 78d18d509475 (2 revisions) (flutter/engine#45769) 2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 3ff43577d04b to 284c333d7eb2 (1 revision) (flutter/engine#45768) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#134676) flutter/engine@5e671d5...b71b366 2023-09-13 matanlurey@users.noreply.github.com Do not run real processes in `clang_tidy_test.dart` (flutter/engine#45748) 2023-09-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds test to verify wide gamut indexed png decompression fix for Skia. (flutter/engine#45399) 2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 284c333d7eb2 to 78d18d509475 (2 revisions) (flutter/engine#45769) 2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 3ff43577d04b to 284c333d7eb2 (1 revision) (flutter/engine#45768) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#133190.
Some context, from @zanderso on chat:
@matanlurey:
@zanderso:
All this PR does is allow providing a
ProcessManager(defaults toLocalProcessManager, i.e.dart:io) throughout the tool. Then, for tests, I've implemented a very minimal fake of bothProcessManagerandProcess(it would be nice to share code w/ say,flutter_tool, but lots of work/overhead for very little surface area).After this CL, no tests in
clang_tidy_test.dartactually run a process. This should unblock adding new features (i.e. original intent of flutter/flutter#133190) without causing headaches for others/CI?