-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Implement TextDecoration (i.e. dashed lines) #45041
[Impeller] Implement TextDecoration (i.e. dashed lines) #45041
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits, and caveat that this isn't a naive implementation its just... the only reasonable way to draw a dashed line with the impeller backend.
@jonahwilliams Looks good for another review. |
We're working on finding a way to test this on CI. |
Ready again for review, thanks @jonahwilliams and @jason-simmons! |
It looks like I'm using a library (
|
This reverts commit 9cf3b19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…133419) flutter/engine@fc59272...0593c04 2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from N-A8agqDgvTKiT2Wc... to jnDJLdEAx34diOWFx... (flutter/engine#45159) 2023-08-27 jonahwilliams@google.com [Impeller] SuboptimalKHR is not an exit condition. (flutter/engine#45157) 2023-08-27 matanlurey@users.noreply.github.com Use YAML >- to avoid strange formatting. (flutter/engine#45158) 2023-08-27 matanlurey@users.noreply.github.com [Impeller] Implement TextDecoration (i.e. dashed lines) (flutter/engine#45041) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from N-A8agqDgvTK to jnDJLdEAx34d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter/flutter#126673. Ideally, this would be an `#ifdef`, but currently Impeller is a runtime flag, for reasons (CI capacity?) ~~To be able to write tests, I'd need flutter/flutter#133264 completed.~~ Edit:  ## Before  ## After <img width="795" alt="Screenshot 2023-08-24 at 9 56 48 AM" src="https://github.com/flutter/engine/assets/168174/0e33f705-6a71-4468-8ec8-372a2e98624e">
Closes flutter/flutter#126673.
Ideally, this would be an
#ifdef
, but currently Impeller is a runtime flag, for reasons (CI capacity?)To be able to write tests, I'd need flutter/flutter#133264 completed.Edit:Before
After