This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision)" #44989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting near tip-of-tree commit without waiting for presubs to finish. |
zanderso
deleted the
revert-44986-dart-sdk-flutter-engine-f39699e4-c261-4597-987c-4f1071851bc1-1692753769
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2023
…sions) (#133106) Manual roll requested by zra@google.com flutter/engine@b190f90...7d56840 2023-08-23 zanderso@users.noreply.github.com Revert "Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision)" (flutter/engine#44989) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... (flutter/engine#44988) 2023-08-23 zanderso@users.noreply.github.com Revert "Make `FontWeight` an enum, Remove unused text classes" (flutter/engine#44987) 2023-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision) (flutter/engine#44986) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... (flutter/engine#44984) 2023-08-23 matanlurey@users.noreply.github.com Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param` (flutter/engine#44936) 2023-08-22 john@johnmccutchan.com Restore old SurfaceTextureExternal drawing code (flutter/engine#44979) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from d0918de21c1a to aa208c8a2d60 (2 revisions) (flutter/engine#44981) 2023-08-22 jason-simmons@users.noreply.github.com Initialize the texture destruction callback in the Metal embedder test harness (flutter/engine#44973) 2023-08-22 matanlurey@users.noreply.github.com Further filter/clear `<SkPaint>.setDither(true)`, this time in `DlSkPaintDispatchHelper` (flutter/engine#44912) 2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 3ebf0fedfceb to ab417bc74bb1 (1 revision) (flutter/engine#44977) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf6019be75ef to d0918de21c1a (3 revisions) (flutter/engine#44975) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from c675298ddeda to bf6019be75ef (3 revisions) (flutter/engine#44974) 2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Make `FontWeight` an enum, Remove unused text classes (flutter/engine#44960) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9f4b81aac175 to c675298ddeda (2 revisions) (flutter/engine#44971) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kKI09su99b0A to VSvpNFoFjqXI fuchsia/sdk/core/mac-amd64 from G25oJMO5jbUi to DoQ8KUxSk-5E If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
|
Is it just this one failure or are there more.
Maybe I could fix this code and then restart the dart roller. |
|
Ignore my comment above, I see more failures. |
|
@a-siva I sent in a forward-fix for flutter/flutter#133152 here dart-lang/sdk@b3c433c. |
Once your forward fix lands in the dev branch I will restart the Dart roller and we can see if we still see failures. If your tryjob did not have errors I don't expect to see errors when we roll. |
|
It looks like that commit is in 3.2.0-101.0.dev, so I'll trigger a manual roll to that version. |
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…flutter#44989) Reverts flutter#44986 Many new analyzer warnings blocking the roll to the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62841/overview cc @kallentu for https://dart.googlesource.com/sdk.git/+/8c2f088481e90949dc04f532af8600b23138ff63 cc @a-siva
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44986
Many new analyzer warnings blocking the roll to the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62841/overview
cc @kallentu for https://dart.googlesource.com/sdk.git/+/8c2f088481e90949dc04f532af8600b23138ff63
cc @a-siva