This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix API typo #4487
Merged
Fix API typo #4487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally something like this (which I forgot I need to put into the wiki). But I am not sure if this qualifies since this API is so new. Was this already pushed out in a roll? |
|
@chinmaygarde The API containing the typo has been public for eight months. Thanks for the link, I'll follow the guidance of that document. |
|
@mravn-google Thanks! Your input on how the mark the APIs unavailable in Java would be great. I only know of |
mravn-google
force-pushed
the
fix_api_typo
branch
from
1f3084e to
c88209c
Compare
sigurdm
reviewed
Jan 2, 2018
| public boolean onRequestPermissionResult( | ||
| int requestCode, String[] permissions, int[] grantResults) { | ||
| return flutterView.getPluginRegistry().onRequestPermissionResult(requestCode, permissions, grantResults); | ||
| return flutterView.getPluginRegistry().onRequestPermissionsResult(requestCode, permissions, grantResults); |
There was a problem hiding this comment.
Call the new method instead
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 25, 2019
In breaking change flutter#4487, a typo was fixed in our Android APIs correcting RequestPermissionResult to RequestPermissionsResult (note the 's' on Permissions) for consistency with the Android SDK. Various tombstone comments were left to help guide developers in the right direction. These comments were slated for removal in March of 2018; at over a year later, we can probably safely remove them.
cbracken
added a commit
that referenced
this pull request
May 25, 2019
In breaking change #4487, a typo was fixed in our Android APIs correcting RequestPermissionResult to RequestPermissionsResult (note the 's' on Permissions) for consistency with the Android SDK. Various tombstone comments were left to help guide developers in the right direction. These comments were slated for removal in March of 2018; at over a year later, we can probably safely remove them.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
In breaking change flutter#4487, a typo was fixed in our Android APIs correcting RequestPermissionResult to RequestPermissionsResult (note the 's' on Permissions) for consistency with the Android SDK. Various tombstone comments were left to help guide developers in the right direction. These comments were slated for removal in March of 2018; at over a year later, we can probably safely remove them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change (posted here)
Plugin registry on Android by mistake renamed the Android concept RequestPermissionsResult to RequestPermissionResult which is unnecessarily confusing.
Fixes flutter/flutter#10853