Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds new builders for partial clang-tidy checks. #44811

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Adds new builders for partial clang-tidy checks. #44811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,25 @@ targets:
- "**.frag"
- "**.vert"

- name: Linux linux_clang_tidy_presubmit
bringup: true
recipe: engine_v2/engine_v2
timeout: 120
properties:
config_name: linux_clang_tidy_presubmit
runIf:
- DEPS
- .ci.yaml
- tools/clang_tidy/**
- ci/builders/**
- ci/clang_tidy.sh
- "**.h"
- "**.c"
- "**.cc"
- "**.fbs"
- "**.frag"
- "**.vert"

- name: Linux linux_arm_host_engine
recipe: engine_v2/engine_v2
timeout: 120
Expand Down Expand Up @@ -360,6 +379,27 @@ targets:
- "**.m"
- "**.mm"

- name: Mac mac_clang_tidy_presubmit
bringup: true
recipe: engine_v2/engine_v2
timeout: 120
properties:
config_name: mac_clang_tidy_presubmit
runIf:
- DEPS
- .ci.yaml
- tools/clang_tidy/**
- ci/builders/**
- ci/clang_tidy.sh
- "**.h"
- "**.c"
- "**.cc"
- "**.fbs"
- "**.frag"
- "**.vert"
- "**.m"
- "**.mm"

- name: Mac mac_host_engine
recipe: engine_v2/engine_v2
timeout: 120
Expand Down
95 changes: 95 additions & 0 deletions ci/builders/linux_clang_tidy_presubmit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
{
"builds": [
{
"name": "android_debug_arm64",
"archives": [],
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--android",
"--android-cpu",
"arm64",
"--no-lto"
],
"ninja": {
"config": "android_debug_arm64"
}
},
{
"name": "host_debug",
"archives": [],
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--runtime-mode",
"debug",
"--prebuilt-dart-sdk",
"--no-lto"
],
"ninja": {
"config": "host_debug"
}
}
],
"tests": [
{
"name": "test: lint host_debug",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Linux",
"cores=32"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"android_debug_arm64"
],
"tasks": [
{
"name": "test: lint host_debug",
"parameters": [
"--variant",
"host_debug",
"--shard-id=0",
"--shard-variants=android_debug_arm64"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
},
{
"name": "test: lint android_debug_arm64",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Linux",
"cores=32"
],
"dependencies": [
"host_debug",
"android_debug_arm64"
],
"tasks": [
{
"name": "test: lint android_debug_arm64",
"parameters": [
"--variant",
"android_debug_arm64",
"--shard-id=1",
"--shard-variants=host_debug"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was clang_tidy script modified in a different PR to include the filtering logic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's existed for awhile for local development.

}
]
}
]
}
114 changes: 114 additions & 0 deletions ci/builders/mac_clang_tidy_presubmit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
{
"builds": [
{
"drone_dimensions": [
"device_type=none",
"os=Mac-12",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
"--prebuilt-dart-sdk",
"--no-lto",
"--force-mac-arm64"
],
"name": "host_debug",
"ninja": {
"config": "host_debug"
}
},
{
"drone_dimensions": [
"device_type=none",
"os=Mac-12",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"gn": [
"--ios",
"--runtime-mode",
"debug",
"--simulator",
"--no-lto",
"--force-mac-arm64"
],
"name": "ios_debug_sim",
"ninja": {
"config": "ios_debug_sim"
}
}
],
"tests": [
{
"name": "test: lint host_debug",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Mac",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"ios_debug_sim"
],
"contexts": [
"osx_sdk"
],
"tasks": [
{
"name": "test: lint host_debug",
"parameters": [
"--variant",
"host_debug",
"--shard-id=0",
"--shard-variants=ios_debug_sim"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
},
{
"name": "test: lint ios_debug_sim",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Mac",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"ios_debug_sim"
],
"contexts": [
"osx_sdk"
],
"tasks": [
{
"name": "test: lint ios_debug_sim",
"parameters": [
"--variant",
"ios_debug_sim",
"--lint-all",
"--shard-id=1",
"--shard-variants=host_debug"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
}
]
}