Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reset editing delta state when replacing editing state #44595

Merged
merged 4 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/text_editing/text_editing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1393,9 +1393,9 @@ abstract class DefaultTextEditingStrategy with CompositionAwareMixin implements
lastEditingState = newEditingState;
_editingDeltaState = newTextEditingDeltaState;
onChange!(lastEditingState, _editingDeltaState);
// Flush delta after it has been sent to framework.
_editingDeltaState = null;
}
// Flush delta state.
_editingDeltaState = null;
}

void handleBeforeInput(DomEvent event) {
Expand Down
20 changes: 20 additions & 0 deletions lib/web_ui/test/engine/text_editing_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2793,6 +2793,26 @@ Future<void> testMain() async {
expect(textEditingDeltaState.composingOffset, -1);
expect(textEditingDeltaState.composingExtent, -1);
});

test('Delta state is cleared after setting editing state', (){
editingStrategy!.enable(
multilineConfig,
onChange: trackEditingState,
onAction: trackInputAction,
);
final DomHTMLInputElement input = editingStrategy!.domElement! as DomHTMLInputElement;
input.value = 'foo bar';
input.dispatchEvent(createDomEvent('Event', 'input'));
expect(
lastEditingState,
EditingState(text: 'foo bar', baseOffset: 7, extentOffset: 7),
);
expect(editingStrategy!.editingDeltaState.oldText, 'foo bar');

editingStrategy!.setEditingState(EditingState(text: 'foo bar baz', baseOffset: 11, extentOffset: 11));
input.dispatchEvent(createDomEvent('Event', 'input'));
expect(editingStrategy?.editingDeltaState.oldText, 'foo bar baz');
});
});

group('text editing styles', () {
Expand Down