[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients #44331

matanlurey · 2023-08-03T17:38:34Z

Partial work towards flutter/flutter#131450 similar to #44181.

Run the Playground locally:

$ENGINE/out/host_debug_unopt/impeller_unittests \
  --enable_playground \
  --gtest_filter="*CanRender*GradientWithDithering*"

Radial

Before

After

Sweep

Before

After

<img width="1018" alt="Screenshot 2023-08-03 at 10 33 11 AM" src="https://github.com/flutter/engine/assets/168174/7e526391-cfd7-4920-89ff-fe26793b24fc"

Conical

Before

After

flutter-dashboard · 2023-08-03T19:12:55Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #44331 at sha b25efd3

jonahwilliams · 2023-08-04T01:37:54Z

I think we have a mysterious 4th gradient type, but maybe that is combined into the radial gradient? The two point conical gradient.

jonahwilliams · 2023-08-04T01:38:30Z

This one: https://github.com/flutter/engine/blob/main/impeller/entity/shaders/conical_gradient_fill.frag

impeller/aiks/aiks_unittests.cc

matanlurey · 2023-08-08T18:57:41Z

I think we have a mysterious 4th gradient type, but maybe that is combined into the radial gradient? The two point conical gradient.

Thanks! Added.

jonahwilliams

LGTM

auto-submit · 2023-08-08T19:02:22Z

auto label is removed for flutter/engine/44331, due to - The status or check suite Linux linux_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams

There was a compiler error: Unsigned integers are not supported on legacy ESSL.

Huh

jonahwilliams · 2023-08-08T19:05:51Z

impeller/entity/shaders/conical_gradient_fill.frag

@@ -45,4 +47,8 @@ void main() {
                                 frag_info.tile_mode,                      //
                                 frag_info.decal_border_color);
  frag_color = IPPremultiply(frag_color) * frag_info.alpha;
+
+  if (frag_info.dither) {


This should be in the _ssbo varaint

auto-submit · 2023-08-08T20:38:05Z

auto label is removed for flutter/engine/44331, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2023-08-08T21:23:56Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #44331 at sha 40cfa90

flutter-dashboard · 2023-08-08T23:05:55Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #44331 at sha 8bda08a

…gradients (flutter/engine#44331)

…132179) flutter/engine@82292b8...29b117a 2023-08-08 matanlurey@users.noreply.github.com [Impeller] Add gradient dithering for Radial/Sweep/Conical gradients (flutter/engine#44331) 2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 68b80f663be6 to 1fbe521b2c56 (2 revisions) (flutter/engine#44518) 2023-08-08 chris@bracken.jp [macOS] Improve engine retain cycle testing (flutter/engine#44509) 2023-08-08 34871572+gmackall@users.noreply.github.com Fix name in description of 'create_cipd_packages.sh' (flutter/engine#44513) 2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] started std::moving `Command`s instead of copying (flutter/engine#44508) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#44331) Partial work towards flutter/flutter#131450 similar to flutter#44181. --- Run the Playground locally: ```bash $ENGINE/out/host_debug_unopt/impeller_unittests \ --enable_playground \ --gtest_filter="*CanRender*GradientWithDithering*" ``` ## Radial ### Before <img width="1014" alt="Screenshot 2023-08-03 at 10 08 53 AM" src="https://github.com/flutter/engine/assets/168174/d53f2c0e-5c48-4ecb-8e67-d4ab28bfe488"> ### After <img width="1018" alt="Screenshot 2023-08-03 at 10 13 57 AM" src="https://github.com/flutter/engine/assets/168174/3b6e6e65-3dd3-4cb3-9950-36e2ba5c1da2"> ## Sweep ### Before <img width="1019" alt="Screenshot 2023-08-03 at 10 27 35 AM" src="https://github.com/flutter/engine/assets/168174/4e3bc82d-c0d5-43dd-952a-c11cb586fb65"> ### After <img width="1018" alt="Screenshot 2023-08-03 at 10 33 11 AM" src="https://github.com/flutter/engine/assets/168174/7e526391-cfd7-4920-89ff-fe26793b24fc" ## Conical ### Before <img width="1019" alt="Screenshot 2023-08-08 at 11 55 43 AM" src="https://github.com/flutter/engine/assets/168174/944709f4-8163-4de3-bfc5-eaf30b978529"> ### After <img width="1016" alt="Screenshot 2023-08-08 at 1 11 40 PM" src="https://github.com/flutter/engine/assets/168174/60ad67a4-b409-4136-a753-b8608f46fbf2">

matanlurey added 2 commits August 3, 2023 10:14

Add dithering for radial gradients.

2da6d06

Add dithering for sweep gradients.

305d83e

github-actions bot added the e: impeller label Aug 3, 2023

Update malioc.

b25efd3

matanlurey self-assigned this Aug 3, 2023

flutter-dashboard bot added the will affect goldens label Aug 3, 2023

chinmaygarde approved these changes Aug 4, 2023

View reviewed changes

impeller/aiks/aiks_unittests.cc Outdated Show resolved Hide resolved

Add conical gradients.

4a47216

jonahwilliams approved these changes Aug 8, 2023

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023

jonahwilliams reviewed Aug 8, 2023

View reviewed changes

matanlurey added 2 commits August 8, 2023 12:06

Update the right fragment shader.

6f439ed

Fix includes.

28d5744

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023

Update malioc.

40cfa90

Avoid junk data polluting frag_info.dither.

8bda08a

matanlurey changed the title ~~[Impeller] Add gradient dithering for Radial and Sweep gradients~~ [Impeller] Add gradient dithering for Radial/Sweep/Conical gradients Aug 8, 2023

matanlurey merged commit 29b117a into flutter:main Aug 8, 2023

matanlurey deleted the impeller-gradient-dithering branch August 8, 2023 23:23

engine-flutter-autoroll mentioned this pull request Aug 9, 2023

Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) flutter/flutter#132179

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2023

29b117aa4 [Impeller] Add gradient dithering for Radial/Sweep/Conical …

51958d0

…gradients (flutter/engine#44331)

reidbaker mentioned this pull request Aug 15, 2023

i82973 scroll mouse wheel support #44724

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients #44331

[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients #44331

Uh oh!

matanlurey commented Aug 3, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Aug 3, 2023

Uh oh!

jonahwilliams commented Aug 4, 2023

Uh oh!

jonahwilliams commented Aug 4, 2023

Uh oh!

Uh oh!

matanlurey commented Aug 8, 2023

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Aug 8, 2023

Uh oh!

jonahwilliams left a comment

Uh oh!

jonahwilliams Aug 8, 2023

Uh oh!

auto-submit bot commented Aug 8, 2023

Uh oh!

flutter-dashboard bot commented Aug 8, 2023

Uh oh!

flutter-dashboard bot commented Aug 8, 2023

Uh oh!

Uh oh!

[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients #44331

[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients #44331

Uh oh!

Conversation

matanlurey commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radial

Before

After

Sweep

Before

After

Conical

Before

After

Uh oh!

flutter-dashboard bot commented Aug 3, 2023

Uh oh!

jonahwilliams commented Aug 4, 2023

Uh oh!

jonahwilliams commented Aug 4, 2023

Uh oh!

Uh oh!

matanlurey commented Aug 8, 2023

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 8, 2023

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 8, 2023

Uh oh!

flutter-dashboard bot commented Aug 8, 2023

Uh oh!

flutter-dashboard bot commented Aug 8, 2023

Uh oh!

Uh oh!

matanlurey commented Aug 3, 2023 •

edited

Loading