Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

move rtree and canvas_spy sources to Fuchsia sub-directory #43615

Merged
merged 1 commit into from
Jul 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/licenses_golden/excluded_files
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
../../../flutter/flow/layers/transform_layer_unittests.cc
../../../flutter/flow/mutators_stack_unittests.cc
../../../flutter/flow/raster_cache_unittests.cc
../../../flutter/flow/rtree_unittests.cc
../../../flutter/flow/skia_gpu_object_unittests.cc
../../../flutter/flow/surface_frame_unittests.cc
../../../flutter/flow/testing
Expand Down Expand Up @@ -212,7 +211,6 @@
../../../flutter/runtime/no_dart_plugin_registrant_unittests.cc
../../../flutter/runtime/type_conversions_unittests.cc
../../../flutter/shell/common/animator_unittests.cc
../../../flutter/shell/common/canvas_spy_unittests.cc
../../../flutter/shell/common/context_options_unittests.cc
../../../flutter/shell/common/dl_op_spy_unittests.cc
../../../flutter/shell/common/engine_unittests.cc
Expand Down Expand Up @@ -292,6 +290,7 @@
../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/build/asset_package.py
../../../flutter/shell/platform/fuchsia/flutter/build/gen_debug_wrapper_main.py
../../../flutter/shell/platform/fuchsia/flutter/canvas_spy_unittests.cc
../../../flutter/shell/platform/fuchsia/flutter/component_v2_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/focus_delegate_unittests.cc
../../../flutter/shell/platform/fuchsia/flutter/fuchsia_intl_unittest.cc
Expand All @@ -303,6 +302,7 @@
../../../flutter/shell/platform/fuchsia/flutter/platform_view_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/pointer_delegate_unittests.cc
../../../flutter/shell/platform/fuchsia/flutter/pointer_injector_delegate_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/rtree_unittests.cc
../../../flutter/shell/platform/fuchsia/flutter/runner_tzdata_missing_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/runner_tzdata_unittest.cc
../../../flutter/shell/platform/fuchsia/flutter/tests
Expand Down
16 changes: 8 additions & 8 deletions ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -841,8 +841,6 @@ ORIGIN: ../../../flutter/flow/raster_cache_key.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/raster_cache_key.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/raster_cache_util.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/raster_cache_util.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/rtree.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/rtree.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/skia_gpu_object.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/surface.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/flow/surface.h + ../../../flutter/LICENSE
Expand Down Expand Up @@ -2188,8 +2186,6 @@ ORIGIN: ../../../flutter/runtime/test_font_data.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/runtime/test_font_data.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/animator.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/animator.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/canvas_spy.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/canvas_spy.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/context_options.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/context_options.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/common/dart_native_benchmarks.cc + ../../../flutter/LICENSE
Expand Down Expand Up @@ -2903,6 +2899,8 @@ ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/service_isolate.h +
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/vmservice/empty.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/canvas_spy.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/canvas_spy.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/component_v2.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/component_v2.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/engine.cc + ../../../flutter/LICENSE
Expand Down Expand Up @@ -2947,6 +2945,8 @@ ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/pointer_delegate.h + ../
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/pointer_injector_delegate.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/pointer_injector_delegate.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/program_metadata.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/rtree.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/rtree.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/runner.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/runner.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/flutter/software_surface.cc + ../../../flutter/LICENSE
Expand Down Expand Up @@ -3528,8 +3528,6 @@ FILE: ../../../flutter/flow/raster_cache_key.cc
FILE: ../../../flutter/flow/raster_cache_key.h
FILE: ../../../flutter/flow/raster_cache_util.cc
FILE: ../../../flutter/flow/raster_cache_util.h
FILE: ../../../flutter/flow/rtree.cc
FILE: ../../../flutter/flow/rtree.h
FILE: ../../../flutter/flow/skia_gpu_object.h
FILE: ../../../flutter/flow/surface.cc
FILE: ../../../flutter/flow/surface.h
Expand Down Expand Up @@ -4878,8 +4876,6 @@ FILE: ../../../flutter/runtime/test_font_data.cc
FILE: ../../../flutter/runtime/test_font_data.h
FILE: ../../../flutter/shell/common/animator.cc
FILE: ../../../flutter/shell/common/animator.h
FILE: ../../../flutter/shell/common/canvas_spy.cc
FILE: ../../../flutter/shell/common/canvas_spy.h
FILE: ../../../flutter/shell/common/context_options.cc
FILE: ../../../flutter/shell/common/context_options.h
FILE: ../../../flutter/shell/common/dart_native_benchmarks.cc
Expand Down Expand Up @@ -5610,6 +5606,8 @@ FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/service_isolate.h
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/vmservice/empty.dart
FILE: ../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/accessibility_bridge.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/canvas_spy.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/canvas_spy.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/component_v2.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/component_v2.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/engine.cc
Expand Down Expand Up @@ -5654,6 +5652,8 @@ FILE: ../../../flutter/shell/platform/fuchsia/flutter/pointer_delegate.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/pointer_injector_delegate.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/pointer_injector_delegate.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/program_metadata.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/rtree.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/rtree.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner.cc
FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner.h
FILE: ../../../flutter/shell/platform/fuchsia/flutter/software_surface.cc
Expand Down
3 changes: 0 additions & 3 deletions flow/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ source_set("flow") {
"raster_cache_key.h",
"raster_cache_util.cc",
"raster_cache_util.h",
"rtree.cc",
"rtree.h",
"skia_gpu_object.h",
"surface.cc",
"surface.h",
Expand Down Expand Up @@ -171,7 +169,6 @@ if (enable_unittests) {
"layers/transform_layer_unittests.cc",
"mutators_stack_unittests.cc",
"raster_cache_unittests.cc",
"rtree_unittests.cc",
"skia_gpu_object_unittests.cc",
"surface_frame_unittests.cc",
"testing/mock_layer_unittests.cc",
Expand Down
1 change: 0 additions & 1 deletion flow/embedded_views.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#include "flutter/display_list/dl_builder.h"
#include "flutter/display_list/skia/dl_sk_canvas.h"
#include "flutter/flow/rtree.h"
#include "flutter/flow/surface_frame.h"
#include "flutter/fml/memory/ref_counted.h"
#include "flutter/fml/raster_thread_merger.h"
Expand Down
3 changes: 0 additions & 3 deletions shell/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ source_set("common") {
sources = [
"animator.cc",
"animator.h",
"canvas_spy.cc",
"canvas_spy.h",
"context_options.cc",
"context_options.h",
"display_manager.cc",
Expand Down Expand Up @@ -295,7 +293,6 @@ if (enable_unittests) {

sources = [
"animator_unittests.cc",
"canvas_spy_unittests.cc",
"context_options_unittests.cc",
"dl_op_spy_unittests.cc",
"engine_unittests.cc",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "flutter/common/task_runners.h"
#include "flutter/flow/embedded_views.h"
#include "flutter/flow/rtree.h"
#include "flutter/shell/platform/android/context/android_context.h"
#include "flutter/shell/platform/android/external_view_embedder/surface_pool.h"
#include "flutter/shell/platform/android/jni/platform_view_android_jni.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <string>

#include "flutter/common/graphics/persistent_cache.h"
#include "flutter/flow/rtree.h"
#include "flutter/fml/platform/darwin/scoped_nsobject.h"
#import "flutter/shell/platform/darwin/common/framework/Headers/FlutterChannels.h"
#import "flutter/shell/platform/darwin/ios/framework/Source/FlutterOverlayView.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define FLUTTER_SHELL_PLATFORM_DARWIN_IOS_FRAMEWORK_SOURCE_FLUTTERPLATFORMVIEWS_INTERNAL_H_

#include "flutter/flow/embedded_views.h"
#include "flutter/flow/rtree.h"
#include "flutter/fml/platform/darwin/scoped_nsobject.h"
#include "flutter/shell/common/shell.h"
#import "flutter/shell/platform/darwin/common/framework/Headers/FlutterBinaryMessenger.h"
Expand Down
6 changes: 6 additions & 0 deletions shell/platform/fuchsia/flutter/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ template("runner_sources") {
sources = [
"accessibility_bridge.cc",
"accessibility_bridge.h",
"canvas_spy.cc",
"canvas_spy.h",
"component_v2.cc",
"component_v2.h",
"engine.cc",
Expand Down Expand Up @@ -94,6 +96,8 @@ template("runner_sources") {
"pointer_injector_delegate.cc",
"pointer_injector_delegate.h",
"program_metadata.h",
"rtree.cc",
"rtree.h",
"runner.cc",
"runner.h",
"software_surface.cc",
Expand Down Expand Up @@ -499,6 +503,7 @@ if (enable_unittests) {

sources = [
"accessibility_bridge_unittest.cc",
"canvas_spy_unittests.cc",
"component_v2_unittest.cc",
"flutter_runner_fakes.h",
"focus_delegate_unittests.cc",
Expand All @@ -507,6 +512,7 @@ if (enable_unittests) {
"platform_view_unittest.cc",
"pointer_delegate_unittests.cc",
"pointer_injector_delegate_unittest.cc",
"rtree_unittests.cc",
"tests/engine_unittests.cc",
"tests/fake_flatland_unittests.cc",
"tests/fake_session_unittests.cc",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "flutter/shell/common/canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/canvas_spy.h"

namespace flutter {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
#include "third_party/skia/include/utils/SkNWayCanvas.h"
#include "third_party/skia/include/utils/SkNoDrawCanvas.h"

#ifndef FLUTTER_SHELL_COMMON_CANVAS_SPY_H_
#define FLUTTER_SHELL_COMMON_CANVAS_SPY_H_
#ifndef FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_CANVAS_SPY_H_
#define FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_CANVAS_SPY_H_

namespace flutter {

Expand Down Expand Up @@ -258,4 +258,4 @@ class DidDrawCanvas final : public SkCanvasVirtualEnforcer<SkNoDrawCanvas> {

} // namespace flutter

#endif // FLUTTER_SHELL_COMMON_SKIA_EVENT_TRACER_IMPL_H_
#endif // FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_CANVAS_SPY_H_
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/canvas_spy.h"

#include "gtest/gtest.h"
#include "third_party/skia/include/core/SkPictureRecorder.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
#include <vector>

#include "flutter/flow/embedded_views.h"
#include "flutter/flow/rtree.h"
#include "flutter/fml/logging.h"
#include "flutter/fml/macros.h"
#include "flutter/shell/common/canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/rtree.h"
#include "third_party/skia/include/core/SkPictureRecorder.h"
#include "third_party/skia/include/core/SkPoint.h"
#include "third_party/skia/include/core/SkRect.h"
Expand Down
4 changes: 2 additions & 2 deletions shell/platform/fuchsia/flutter/gfx_external_view_embedder.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
#include <vector>

#include "flutter/flow/embedded_views.h"
#include "flutter/flow/rtree.h"
#include "flutter/fml/logging.h"
#include "flutter/fml/macros.h"
#include "flutter/shell/common/canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/canvas_spy.h"
#include "flutter/shell/platform/fuchsia/flutter/rtree.h"
#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkPictureRecorder.h"
#include "third_party/skia/include/core/SkPoint.h"
Expand Down
2 changes: 1 addition & 1 deletion flow/rtree.cc → shell/platform/fuchsia/flutter/rtree.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "rtree.h"
#include "flutter/shell/platform/fuchsia/flutter/rtree.h"

#include <list>

Expand Down
6 changes: 3 additions & 3 deletions flow/rtree.h → shell/platform/fuchsia/flutter/rtree.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef FLUTTER_FLOW_RTREE_H_
#define FLUTTER_FLOW_RTREE_H_
#ifndef FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_RTREE_H_
#define FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_RTREE_H_

#include <list>
#include <map>
Expand Down Expand Up @@ -62,4 +62,4 @@ class RTreeFactory : public SkBBHFactory {

} // namespace flutter

#endif // FLUTTER_FLOW_RTREE_H_
#endif // FLUTTER_SHELL_PLATFORM_FUCHSIA_FLUTTER_RTREE_H_
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "rtree.h"
#include "flutter/shell/platform/fuchsia/flutter/rtree.h"

#include "flutter/testing/testing.h"
#include "third_party/skia/include/core/SkCanvas.h"
Expand Down