This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add osx_sdk context to mac_clang_tidy #43115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this depend on the recipes change? |
This is a no-op if landing before the recipes cl changes, but will take effect only after the recipes cl lands. |
godofredoc
approved these changes
Jun 23, 2023
keyonghan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 23, 2023
…129440) flutter/engine@cd30a48...060cd9c 2023-06-23 chillers@google.com [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139) 2023-06-23 54558023+keyonghan@users.noreply.github.com Add osx_sdk context to mac_clang_tidy (flutter/engine#43115) 2023-06-23 jonahwilliams@google.com [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken
pushed a commit
to cbracken/flutter_recipes
that referenced
this pull request
May 29, 2024
This CL: 1) put xcode installation under context 2) put contexts arguments to api.flutter_deps.contexts, instead of appending arguments at each context iteration. This makes the module to handle more general cases not limited to (env, env_prefix). LED run based on flutter/engine#43115: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/57dfaf1802c4b6aeae753e5a70c4993301edf90d88fa6dc06e5296b890434974/+/build.proto Change-Id: Iad47e624c2ae3625b424e5610199d332d1709c6a Bug: flutter/flutter#129366 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/46380 Reviewed-by: Godofredo Contreras <godofredoc@google.com> Commit-Queue: Keyong Han <keyonghan@google.com>
cbracken
pushed a commit
to cbracken/flutter_recipes
that referenced
this pull request
May 29, 2024
This reverts commit 5bc9d9d. Reason for revert: This caused engine tree closure. Original change's description: > Run mac test under xcode for tester_engine > > This CL: > 1) put xcode installation under context > 2) put contexts arguments to api.flutter_deps.contexts, instead of appending arguments at each context iteration. This makes the module to handle more general cases not limited to (env, env_prefix). > > LED run based on flutter/engine#43115: > https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/57dfaf1802c4b6aeae753e5a70c4993301edf90d88fa6dc06e5296b890434974/+/build.proto > > Change-Id: Iad47e624c2ae3625b424e5610199d332d1709c6a > Bug: flutter/flutter#129366 > Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/46380 > Reviewed-by: Godofredo Contreras <godofredoc@google.com> > Commit-Queue: Keyong Han <keyonghan@google.com> TBR=godofredoc@google.com,keyonghan@google.com,flutter-scoped@luci-project-accounts.iam.gserviceaccount.com,ricardoamador@google.com Change-Id: I2e39b25f894b13c13e9b7d25bb1a54eeb6e4ee10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: flutter/flutter#129366 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/46521 Reviewed-by: Keyong Han <keyonghan@google.com> Commit-Queue: Keyong Han <keyonghan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With context, recipes logic should be simplified without checking corresponding platform/property conditions.
With the
osx_sdkcontext, it will install xcode accordingly.