This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[cp] only recycle maskView when the view is applying mutators #43007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plying mutators flutter#42115" (flutter#42823) Relands flutter#42115, which was reverted in flutter#42231 due to a crash in the framework test. The crash is due to a memory management issue that I fixed it in this PR, I also added a scenario test to catch the crash. fixes: flutter/flutter#125620 See also: orignal PR flutter#41573 for more details. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
@hellohuanlin was the reviewer for the original PR. Also add @stuartmorgan as he is the iOS TL. |
hellohuanlin
approved these changes
Jun 20, 2023
shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm
Show resolved
Hide resolved
XilaiZhang
added
the
autosubmit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp #42823.
The PR fixes flutter/flutter#125620, which was a regression caused by #38989. We cannot simply revert #38989 because #38989 addressed a critical performance issue
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.