This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Predictive back breakage fix #42789
Merged
Predictive back breakage fix #42789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
approved these changes
Jun 12, 2023
| * <p>Relevant for registering and unregistering the app's OnBackInvokedCallback for the | ||
| * Predictive Back feature. | ||
| */ | ||
| default void setFrameworkHandlesBack(boolean frameworkHandlesBack) {} |
There was a problem hiding this comment.
I think this works as a good alternative to the empty implementation in FlutterFragment. Maybe the doc can expand on where this is currently relevant (FlutterActivity alone now I suppose)?
| @@ -517,7 +517,7 @@ public interface PlatformMessageHandler { | |||
| void setSystemUiOverlayStyle(@NonNull SystemChromeStyle systemUiOverlayStyle); | |||
|
|
|||
| /** The Flutter application would or would not like to handle navigation pop events itself. */ | |||
| void setFrameworkHandlesBack(boolean frameworkHandlesBack); | |||
| default void setFrameworkHandlesBack(boolean frameworkHandlesBack) {} | |||
There was a problem hiding this comment.
This makes sense to me since it is only used in a particular place. I'd suggest expanding the doc to mention where exactly this is relevant currently (FlutterActivity), just so it's clear we don't expect it to work or be used elsewhere.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2023
…128754) flutter/engine@f67ed35...d02b15e 2023-06-12 jonahwilliams@google.com [Impeller] Fix text jitter on Vulkan. (flutter/engine#42792) 2023-06-12 jmccandless@google.com Predictive back breakage fix (flutter/engine#42789) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix breakage(s) caused by #39208.
b/286627757
Main problem
There were breakages in Google's code where classes that implemented PlatformMessageHandler did not provide an implementation of setFrameworkHandlesBack.
I've tried to fix this by adding a default empty implementation to PlatformMessageHandler. Is that ok to do there, even though other nearby methods don't have default implementations there?
Also, I noticed that I could probably do the same thing to avoid my empty implementation in FlutterFragment, so I added one to PlatformPluginDelegate as well. That did allow me to remove the implementation in FlutterFragment. Is that ok as well? Do I need to provide both empty implementations?
Other cleanup
I noticed that when I renamed frameworkHandlesBacks to frameworkHandlesBack, I forgot to rename some cases, which I've cleaned up here.