This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Bump the target API level to 12, and pass it to fidlc #42667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From Engine PR review triage: This PR will need to have a Fuchsia expert added as a reviewer. |
tarobins
reviewed
Jun 8, 2023
| @@ -22,6 +22,9 @@ template("fidl_library") { | |||
|
|
|||
| assert(defined(invoker.sources), "A FIDL library requires some sources.") | |||
|
|
|||
| assert(fuchsia_target_api_level != -1, | |||
There was a problem hiding this comment.
are there existing usages of this template? is fuchsia_target_api_level set for all on them?
There was a problem hiding this comment.
Yes it's used to make FIDL bindings for Fuchsia SDK libraries (see tools/fuchsia/sdk/sdk_targets.gni). I copied the != -1 assertion from tools/fuchsia/fuchsia_archive.gni. fuchsia_target_api_level is a global GN arg set here https://github.com/flutter/engine/blob/main/tools/gn#L570. The build should fail if there's a case where it's not set.
|
Generally LGTM, but before merging I pinged mitchell offline with some questions I have |
This bumps the target Fuchsia API level from 11 to 12. It also makes the GN build pass the API level to fidlc. Previously it relied on the fidlc default of HEAD, meaning all FIDL changes were immediately visible when the SDK rolls. This was never the intention: flutter should be targeting a specific API level. This unblocks https://fxrev.dev/864297 which makes the fidlc --available flag required, and which uncovered this problem. I also copied the changes to gen_response_file.py from https://fxrev.dev/865020 to make it forward --available to fidlc.
mk12
changed the title
|
Amended to also bump the API level to 12 as discussed with @arbreng |
|
LGTM |
tarobins
approved these changes
Jun 9, 2023
|
No, I just don't know what I'm doing. |
|
👍 Thanks. Looks like I still can't merge even with approval, could you do that as well? |
arbreng
approved these changes
Jun 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 9, 2023
…sions) (#128554) Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) Manual roll requested by zra@google.com flutter/engine@a5f7d5d...8f9e608 2023-06-09 zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688) 2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667) 2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687) 2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682) 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684) 2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680) 2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679) 2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677) 2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678) 2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673) 2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648) 2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409) 2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675) 2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668) 2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662) 2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660) 2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659) 2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658) 2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651) 2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622) 2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645) 2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646) 2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638) 2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the GN build pass the target Fuchsia API level to fidlc. Currently it relies on the default of HEAD, meaning all FIDL changes are immediately visible when the SDK rolls. This was never the intention: flutter should be targeting a specific API level.
This unblocks https://fxrev.dev/864297 which makes the fidlc --available flag required, and which uncovered this problem.
I also copied the changes to gen_response_file.py from https://fxrev.dev/865020 to make it forward --available to fidlc.