[Impeller] Compute in Vulkan

impeller/playground/compute_playground_test.h

@@ -55,6 +55,15 @@ class ComputePlaygroundTest
   FML_DISALLOW_COPY_AND_ASSIGN(ComputePlaygroundTest);
 };
 
+// TODO(dnfield): Remove this macro as Vulkan support reaches parith with Metal.
+#define INSTANTIATE_COMPUTE_SUITE_WITH_VULKAN(playground)                  \
+  INSTANTIATE_TEST_SUITE_P(                                                \
+      Compute, playground,                                                 \
+      ::testing::Values(PlaygroundBackend::kMetal,                         \
+                        PlaygroundBackend::kVulkan),                       \
+      [](const ::testing::TestParamInfo<ComputePlaygroundTest::ParamType>& \
+             info) { return PlaygroundBackendToString(info.param); });
+
 #define INSTANTIATE_COMPUTE_SUITE(playground)                              \
   INSTANTIATE_TEST_SUITE_P(                                                \
       Compute, playground, ::testing::Values(PlaygroundBackend::kMetal),   \

impeller/renderer/backend/vulkan/capabilities_vk.cc

@@ -295,6 +295,19 @@ bool CapabilitiesVK::SetDevice(const vk::PhysicalDevice& device) {
 
   device_properties_ = device.getProperties();
 
+  auto physical_properties_2 =
+      device.getProperties2<vk::PhysicalDeviceProperties2,
+                            vk::PhysicalDeviceSubgroupProperties>();
+
+  // Currently shaders only want access to arithmetic subgroup features.
+  // If that changes this needs to get updated, and so does Metal (which right
+  // now assumes it from compile time flags based on the MSL target version).
+
+  supports_compute_subgroups_ =
+      !!(physical_properties_2.get<vk::PhysicalDeviceSubgroupProperties>()
+             .supportedOperations &
+         vk::SubgroupFeatureFlagBits::eArithmetic);
+
   return true;
 }
 
@@ -330,12 +343,14 @@ bool CapabilitiesVK::SupportsFramebufferFetch() const {
 
 // |Capabilities|
 bool CapabilitiesVK::SupportsCompute() const {
-  return false;
+  // Vulkan 1.1 requires support for compute.
+  return true;
 }
 
 // |Capabilities|
 bool CapabilitiesVK::SupportsComputeSubgroups() const {
-  return false;
+  // Set by |SetDevice|.
+  return supports_compute_subgroups_;
 }
 
 // |Capabilities|

impeller/renderer/backend/vulkan/capabilities_vk.h

@@ -91,6 +91,7 @@ class CapabilitiesVK final : public Capabilities,
   PixelFormat color_format_ = PixelFormat::kUnknown;
   PixelFormat depth_stencil_format_ = PixelFormat::kUnknown;
   vk::PhysicalDeviceProperties device_properties_;
+  bool supports_compute_subgroups_ = false;
   bool is_valid_ = false;
 
   bool HasExtension(const std::string& ext) const;

impeller/renderer/compute_pass.cc

@@ -38,7 +38,8 @@ void ComputePass::SetThreadGroupSize(const ISize& size) {
 
 bool ComputePass::AddCommand(ComputeCommand command) {
   if (!command) {
-    VALIDATION_LOG << "Attempted to add an invalid command to the render pass.";
+    VALIDATION_LOG
+        << "Attempted to add an invalid command to the compute pass.";
     return false;
   }
 

impeller/renderer/compute_subgroup_unittests.cc

@@ -39,6 +39,15 @@ namespace testing {
 using ComputeSubgroupTest = ComputePlaygroundTest;
 INSTANTIATE_COMPUTE_SUITE(ComputeSubgroupTest);
 
+using ComputeMetalAndVulkanSubgroupTest = ComputePlaygroundTest;
+INSTANTIATE_COMPUTE_SUITE_WITH_VULKAN(ComputeMetalAndVulkanSubgroupTest);
+
+TEST_P(ComputeMetalAndVulkanSubgroupTest, CapabilitiesSuportSubgroups) {
+  auto context = GetContext();
+  ASSERT_TRUE(context);
+  ASSERT_TRUE(context->GetCapabilities()->SupportsComputeSubgroups());
+}
+
 TEST_P(ComputeSubgroupTest, PathPlayground) {
   // Renders stroked SVG paths in an interactive playground.
   using SS = StrokeComputeShader;

impeller/renderer/compute_unittests.cc

@@ -25,6 +25,15 @@ namespace testing {
 using ComputeTest = ComputePlaygroundTest;
 INSTANTIATE_COMPUTE_SUITE(ComputeTest);
 
+using ComputeMetalAndVulkanSubgroupTest = ComputePlaygroundTest;
+INSTANTIATE_COMPUTE_SUITE_WITH_VULKAN(ComputeMetalAndVulkanSubgroupTest);
+
+TEST_P(ComputeMetalAndVulkanSubgroupTest, CapabilitiesReportSupport) {
+  auto context = GetContext();
+  ASSERT_TRUE(context);
+  ASSERT_TRUE(context->GetCapabilities()->SupportsCompute());
+}
+
 TEST_P(ComputeTest, CanCreateComputePass) {
   using CS = SampleComputeShader;
   auto context = GetContext();