This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate linux unopt to engine_v2. #41658
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| { | ||
| "builds": [ | ||
| { | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Linux" | ||
| ], | ||
| "gclient_variables": { | ||
| "download_android_deps": false | ||
| }, | ||
| "gn": [ | ||
| "--runtime-mode", | ||
| "debug", | ||
| "--unoptimized", | ||
| "--prebuilt-dart-sdk", | ||
| "--asan", | ||
| "--lsan", | ||
| "--dart-debug" | ||
| ], | ||
| "name": "host_debug_unopt", | ||
| "ninja": { | ||
| "config": "host_debug_unopt", | ||
| "targets": [ | ||
| "flutter/tools/font-subset", | ||
| "flutter:unittests", | ||
| "flutter/build/dart:copy_dart_sdk", | ||
| "flutter/shell/platform/common/client_wrapper:client_wrapper_unittests", | ||
| "flutter/shell/platform/common:common_cpp_core_unittests", | ||
| "flutter/shell/platform/common:common_cpp_unittests", | ||
| "flutter/shell/platform/glfw/client_wrapper:client_wrapper_glfw_unittests", | ||
| "flutter/shell/testing", | ||
| "sky_engine" | ||
| ] | ||
| }, | ||
| "tests": [ | ||
| { | ||
| "name": "test:format_and_dart_test", | ||
| "script": "flutter/ci/format.sh" | ||
| }, | ||
| { | ||
| "language": "python3", | ||
| "name": "test: Host_Tests_for_host_debug_unopt", | ||
| "parameters": [ | ||
| "--variant", | ||
| "host_debug_unopt", | ||
| "--type", | ||
| "dart,engine", | ||
| "--engine-capture-core-dump", | ||
| "--use-sanitizer-suppressions" | ||
| ], | ||
| "script": "flutter/testing/run_tests.py" | ||
| }, | ||
| { | ||
| "name": "analyze_dart_ui", | ||
| "script": "flutter/ci/analyze.sh" | ||
| }, | ||
| { | ||
| "language": "dart", | ||
| "name": "test: observatory and service protocol", | ||
| "script": "flutter/shell/testing/observatory/test.dart", | ||
| "parameters": [ | ||
| "out/host_debug_unopt/flutter_tester", | ||
| "flutter/shell/testing/observatory/empty_main.dart" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Linux" | ||
| ], | ||
| "dependencies": [ | ||
| { | ||
| "dependency": "arm_tools", | ||
| "version": "last_updated:2023-02-03T15:32:01-0800" | ||
| } | ||
| ], | ||
| "gn": [ | ||
| "--android", | ||
| "--unoptimized" | ||
| ], | ||
| "name": "android_debug_unopt", | ||
| "ninja": { | ||
| "config": "android_debug_unopt", | ||
| "targets": [ | ||
| "flutter/impeller", | ||
| "flutter/shell/platform/android:android_jar", | ||
| "flutter/shell/platform/android:robolectric_tests" | ||
| ] | ||
| }, | ||
| "tests": [ | ||
| { | ||
| "language": "python3", | ||
| "name": "test: Host Tests for android_debug_unopt", | ||
| "parameters": [ | ||
| "--variant", | ||
| "android_debug_unopt", | ||
| "--type", | ||
| "java", | ||
| "--engine-capture-core-dump", | ||
| "--android-variant", | ||
| "android_debug_unopt" | ||
| ], | ||
| "script": "flutter/testing/run_tests.py" | ||
| }, | ||
| { | ||
| "language": "python3", | ||
| "name": "malioc diff", | ||
| "parameters": [ | ||
| "--before-relative-to-src", | ||
| "flutter/impeller/tools/malioc.json", | ||
| "--after-relative-to-src", | ||
| "out/android_debug_unopt/gen/malioc", | ||
| "--print-diff" | ||
| ], | ||
| "script": "flutter/impeller/tools/malioc_diff.py" | ||
|
There was a problem hiding this comment. This won't do anything unless the path to malioc is passed to There was a problem hiding this comment. The arm-tool dep is setting up the env variable that gn looks for: https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/flutter_deps/api.py;l=173 There was a problem hiding this comment. |
||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this keep the 3x retry and alerting the engine sheriff on a flake? https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine_unopt.py#79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests in v2 are reusing the same logic https://cs.opensource.google/flutter/recipes/+/main:recipes/engine_v2/builder.py;l=127