Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Add dart:js_interop_unsafe to SDK. #41591

Merged
merged 1 commit into from
May 3, 2023

Conversation

joshualitt
Copy link
Contributor

Adds the dart:js_interop_unsafe library to the SDK.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 28, 2023
@joshualitt joshualitt force-pushed the add-js-interop-unsafe branch from 5d0f79c to deed13f Compare April 28, 2023 17:59
@joshualitt
Copy link
Contributor Author

@eyebrowsoffire ptal

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshualitt joshualitt merged commit d2dce25 into flutter:main May 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 3, 2023
…125989)

flutter/engine@b71728b...7d70dc8

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698)
2023-05-03 joshualitt@google.com [web] Add `dart:js_interop_unsafe` to SDK. (flutter/engine#41591)
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9T4mGpfsJZO0 to n1UnzmslAzt0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants