reland "Migrate mac_host_engine to engine v2 builds." #41531
Conversation
This reverts commit f6e64a8.
|
Validated with https://github.com/flutter/flutter/pull/119969/checks |
godofredoc
added
the
autosubmit
auto-submit
bot
deleted the
revert-41233-revert-41149-migrate_host_engine
branch
…125598) flutter/engine@19045bb...689eb6e 2023-04-27 godofredoc@google.com reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41531) 2023-04-27 zanderso@users.noreply.github.com Roll buildroot to 5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@godofredoc @zanderso This PR along with d8e86b5 seems to have caused Apple to reject MacOS builds as outlined in flutter/flutter#126705 Are there any official workarounds or some migration steps that need to be taken in order for the build to get accepted? |
|
@borjandev Does this reproduce with a newer commit? |
|
@godofredoc Yes, every single commit after master flutter/flutter@3d25049 gets rejected with the same ITMS-90238: Invalid Signature issue Last good commit that gets properly accepted is Took me quite a lot of compiles and submissions to isolate the commit |
|
Let's continue the discussion in the bug |
Relands: #41149
GN+Ninja artifacts have been validated manually. The number of files and their content is the same and presubmit tests are passing correctly in the engine and flutter.
The reason of previous reverts are:
Full details of what has been fixed can be found in: flutter/flutter#124911