This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add debug ToString methods to render targets. #41221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Apr 14, 2023
Comment on lines
12
to
+27
| std::string SPrintF(const char* format, ...) { | ||
| std::string ret_val; | ||
| va_list list; | ||
| va_list list2; | ||
| va_start(list, format); | ||
| char buffer[64] = {0}; | ||
| ::vsnprintf(buffer, sizeof(buffer), format, list); | ||
| va_copy(list2, list); | ||
| if (auto string_length = ::vsnprintf(nullptr, 0, format, list); | ||
| string_length >= 0) { | ||
| auto buffer = reinterpret_cast<char*>(::malloc(string_length + 1)); | ||
| ::vsnprintf(buffer, string_length + 1, format, list2); | ||
| ret_val = std::string{buffer, static_cast<size_t>(string_length)}; | ||
| ::free(buffer); | ||
| } | ||
| va_end(list2); | ||
| va_end(list); | ||
| return buffer; | ||
| return ret_val; |
There was a problem hiding this comment.
I'll take your word for this.
There was a problem hiding this comment.
Are you talking about the dubious var name?
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41221, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Also fixes and issue where SPrintF would only consider strings 64 bytes or smaller.
chinmaygarde
added
the
autosubmit
|
The CI flake has been reported in sheriffs chat. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2023
…125004) flutter/engine@20034a8...4a603aa 2023-04-17 magder@google.com Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226) 2023-04-17 chinmaygarde@google.com [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes and issue where SPrintF would only consider strings 64 bytes or smaller.