This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Don't run goldctl init more than once #41207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
eyebrowsoffire
suggested changes
Apr 14, 2023
| @@ -495,5 +481,12 @@ class SkiaGoldClient { | |||
| } | |||
| } | |||
|
|
|||
| Future<void>? _oneResult; | |||
There was a problem hiding this comment.
I don't think we can make this a global, it needs to be per SkiaGoldClient. We have separate gold clients per suite now.
There was a problem hiding this comment.
Done.
Nice catch! I've been contemplating making it per client instead of global but didn't find a good reason to do that. Totally forgot that we run multiple suites at the same time now.
eyebrowsoffire
approved these changes
Apr 14, 2023
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
…124896) flutter/engine@413e95d...e9739bc 2023-04-14 chris@bracken.jp [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 mdebbar@google.com [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 skia-flutter-autoroll@skia.org Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 chillers@google.com Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 magder@google.com Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 magder@google.com Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124896) flutter/engine@413e95d...e9739bc 2023-04-14 chris@bracken.jp [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 mdebbar@google.com [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 skia-flutter-autoroll@skia.org Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 chillers@google.com Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 magder@google.com Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 magder@google.com Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the logs reported in flutter/flutter#124864 I noticed we are making multiple calls to
goldctl initwhich could be causing some race conditions with thegoldctl imgtest addcalls.This PR makes sure we only call
goldctl initonce.