This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change v2 mac_unopt orchestrator builder to Linux
#41184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
changed the title
mac_unopt orchestrator builder to Linux
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jmagman
added
autosubmit
zanderso
approved these changes
Apr 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2023
…124900) flutter/engine@e9739bc...f794529 2023-04-14 magder@google.com Change v2 `mac_unopt` orchestrator builder to Linux (flutter/engine#41184) 2023-04-14 zanderso@users.noreply.github.com Specify allowed Macmini models (flutter/engine#41219) 2023-04-14 godofredoc@google.com Migrate mac_host_engine to engine v2 builds. (flutter/engine#41149) 2023-04-14 magder@google.com Remove cores dimension from Mac Host clang-tidy (flutter/engine#41214) 2023-04-14 magder@google.com Run mac_host_engine orchestrator on arm Macs (flutter/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124900) flutter/engine@e9739bc...f794529 2023-04-14 magder@google.com Change v2 `mac_unopt` orchestrator builder to Linux (flutter/engine#41184) 2023-04-14 zanderso@users.noreply.github.com Specify allowed Macmini models (flutter/engine#41219) 2023-04-14 godofredoc@google.com Migrate mac_host_engine to engine v2 builds. (flutter/engine#41149) 2023-04-14 magder@google.com Remove cores dimension from Mac Host clang-tidy (flutter/engine#41214) 2023-04-14 magder@google.com Run mac_host_engine orchestrator on arm Macs (flutter/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
`Linux mac_unopt`: https://ci.chromium.org/p/flutter/builders/try/Linux%20mac_unopt/4 Remove `bringup` and remove `Mac mac_unopt` in favor of the Linux orchestrator #41184 Add the `xcode` version to the mac_unopt json file since it's no longer being inherited from `Mac mac_unopt`. Fixes flutter/flutter#124912
drewroengoogle
pushed a commit
that referenced
this pull request
Jul 25, 2023
`mac_unopt` orchestrator kicks off Mac swarming tasks, but don't seem to need to run on a Mac. Swap Linux bots which are more plentiful and have a shorter queue time. Start by adding new `bringup` builder to see if it passes in staging. If it passes I will remove the Mac variant ASAP. Led run: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/49f579a1636ddec2ffc05cb6053196a4472f5e4f69034386f88824356c479621/+/build.proto Keep `mac_ios_engine` and `mac_host_engine` as Macs since they need to run Xcodes on Macs to create the xcframeworks. See also #41181 and #41210
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac_unoptorchestrator kicks off Mac swarming tasks, but don't seem to need to run on a Mac. Swap Linux bots which are more plentiful and have a shorter queue time.Start by adding new
bringupbuilder to see if it passes in staging. If it passes I will remove the Mac variant ASAP.Led run: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/49f579a1636ddec2ffc05cb6053196a4472f5e4f69034386f88824356c479621/+/build.proto
Keep
mac_ios_engineandmac_host_engineas Macs since they need to run Xcodes on Macs to create the xcframeworks.See also #41181 and #41210