[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. #40746

ksballetba · 2023-03-29T02:46:18Z

Fix:

Flutter TextField focus state is not correct when keyboard closed from platform side. flutter#123523

Before this patch:

before.fix.mp4

After this patch:

after.fix.mp4

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

…correct.

…s state is correct.

flutter-dashboard · 2023-03-29T02:46:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

reidbaker

This looks reasonable to me but I would like and LGTM from someone who understands this code better. Possibly @LongCatIsLooong

chinmaygarde · 2023-04-06T20:06:08Z

Ping @LongCatIsLooong for +1.

chinmaygarde

@LongCatIsLooong is going to be OOO for a couple of weeks. We eyeballed this in triage and it seemed fine.

luckysmg · 2023-04-14T03:04:28Z

Thx @chinmaygarde ^_^ .

Adding label for merging. ^_^

…le to ensure framework focus state is correct. (flutter#40746) [Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct.

…es invisible to ensure framework focus state is correct. (flutter/engine#40746)

… invisible to ensure framework focus state is correct. (#40746)" This reverts commit c9adff6.

… invisible to ensure framework focus state is correct." (#41211) Reverts #40746 Googler bug: b/278174021 Failing on ``` shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java:239: Error: This method should only be accessed from tests or within private scope [VisibleForTests] imeSyncCallback.remove(); ```

luckysmg · 2023-04-24T11:40:14Z

Emm any plan to reland this? I think this is necessary. What changes we should make to reland this?
@reidbaker Do you have any advice?

luckysmg · 2023-04-24T12:09:10Z

@CaseyHillers @reidbaker I think the issue in revert PR is still exists on main channel.

See #41211 (comment)

And code in still have issue:

engine/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java

Line 90 in 5fbde6c

imeSyncCallback =

Maybe it is not on the PR #40746

I m not sure we should use @SuppressLint({"NewApi", "VisibleForTests"}) to solve it.

Just like:

ksballetba · 2023-04-24T12:16:32Z

set otherwise to VisibleForTesting.PACKAGE_PRIVATE for VisibleForTesting annotation could solve this problem.

luckysmg · 2023-04-24T12:27:16Z

Yes. See the same usage in FlutterEngine.java I think this is a good idea to solve.

MeandNi · 2023-11-20T14:39:10Z

I think this PR is unnecessary. Is there a situation where I want to keep the focus when the keyboard disappears? For example, when I pop up a custom emoji picker, I will put away the keyboard. At this time, I want the focus to remain on above the input box.

As for the situation described above, we can choose focus state by observing whether the keyboard is visible.

cc\ @ksballetba @reidbaker

ksballetba added 2 commits March 28, 2023 20:09

[Android] Send unfocus message to framework to ensure focus state is …

09f2260

…correct.

[Android] Send onConnectionClosed message to framework to ensure focu…

3dec297

…s state is correct.

flutter-dashboard bot added the platform-android label Mar 29, 2023

flutter-dashboard bot added the needs tests label Mar 29, 2023

luckysmg mentioned this pull request Mar 29, 2023

Flutter TextField focus state is not correct when keyboard closed from platform side. flutter/flutter#123523

Closed

3 tasks

ksballetba and others added 3 commits March 29, 2023 11:00

Merge branch 'main' into handle_unfocus

8e5b2de

add test.

86cc4a2

add test.

61f6e6c

luckysmg assigned ksballetba Mar 29, 2023

ksballetba added 3 commits March 29, 2023 13:03

add test.

b093212

fix test problem.

e5b1867

fix nits.

6570eaa

luckysmg requested review from LongCatIsLooong and reidbaker and removed request for LongCatIsLooong March 29, 2023 05:51

luckysmg removed the needs tests label Mar 29, 2023

luckysmg requested a review from jason-simmons March 29, 2023 05:52

reidbaker reviewed Mar 29, 2023

View reviewed changes

reidbaker approved these changes Mar 29, 2023

View reviewed changes

ksballetba changed the title ~~[Android] Send unfocus message to framework to ensure focus state is correct.~~ [Android] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. Mar 30, 2023

luckysmg changed the title ~~[Android] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct.~~ [Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. Apr 11, 2023

chinmaygarde approved these changes Apr 13, 2023

View reviewed changes

luckysmg added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023

auto-submit bot merged commit c9adff6 into flutter:main Apr 14, 2023

engine-flutter-autoroll mentioned this pull request Apr 14, 2023

Roll Flutter Engine from 00bef00f64a7 to 4f86a05ac932 (5 revisions) flutter/flutter#124841

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023

c9adff6f4 [Android] Send connectionClosed message when keyboard becom…

32eed63

…es invisible to ensure framework focus state is correct. (flutter/engine#40746)

CaseyHillers added a commit that referenced this pull request Apr 14, 2023

Revert "[Android] Send connectionClosed message when keyboard becomes…

51f84f8

… invisible to ensure framework focus state is correct. (#40746)" This reverts commit c9adff6.

CaseyHillers mentioned this pull request Apr 14, 2023

Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." #41211

Merged

luckysmg added the customer: alibaba label Apr 24, 2023

luckysmg mentioned this pull request May 5, 2023

Close connection on keyboard close #41500

Merged

8 tasks

MeandNi mentioned this pull request Dec 21, 2023

Whether focus exists has nothing to do with whether the keyboard is open flutter/flutter#140508

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. #40746

[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. #40746

Uh oh!

ksballetba commented Mar 29, 2023

Uh oh!

flutter-dashboard bot commented Mar 29, 2023

Uh oh!

reidbaker left a comment

Uh oh!

chinmaygarde commented Apr 6, 2023 •

edited

Loading

Uh oh!

chinmaygarde left a comment

Uh oh!

luckysmg commented Apr 14, 2023 •

edited

Loading

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

ksballetba commented Apr 24, 2023

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

MeandNi commented Nov 20, 2023 •

edited

Loading

Uh oh!

Uh oh!

[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. #40746

[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct. #40746

Uh oh!

Conversation

ksballetba commented Mar 29, 2023

Before this patch:

After this patch:

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 29, 2023

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

luckysmg commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

ksballetba commented Apr 24, 2023

Uh oh!

luckysmg commented Apr 24, 2023

Uh oh!

MeandNi commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

chinmaygarde commented Apr 6, 2023 •

edited

Loading

luckysmg commented Apr 14, 2023 •

edited

Loading

MeandNi commented Nov 20, 2023 •

edited

Loading