Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix EntityPass target flip for Vulkan #40701

Merged
merged 2 commits into from
Mar 28, 2023
Merged

[Impeller] Fix EntityPass target flip for Vulkan #40701

merged 2 commits into from
Mar 28, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Mar 28, 2023

Re-enables AiksTest.CanRenderClippedLayers and DisplayListTest.CanDrawBackdropFilter for Vulkan.

  • Use the resolve texture descriptor when making the second texture instead of the texture field (this was the real bug).
  • Removed the non-MSAA logic from EntityPassTarget::Flip, as it should only ever be called when MSAA is in use.

@bdero bdero self-assigned this Mar 28, 2023
@bdero bdero requested a review from chinmaygarde March 28, 2023 05:00
@bdero bdero changed the title [Impeller] Fix EntityPass target flip [Impeller] Fix EntityPass target flip for Vulkan Mar 28, 2023
@bdero bdero merged commit 3f7b939 into flutter:main Mar 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
3f7b9390d [Impeller] Fix EntityPass target flip (flutter/engine#40701)
03b0387
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

@bdero bdero

Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdero @chinmaygarde