Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule" #40686

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule" #40686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c488a99
Revert "Return an empty JavaScript object as a replacement for export…
bdero Mar 27, 2023
9bf0994
Merge branch 'main' into revert-40582-bug_123219
bdero Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2660,7 +2660,7 @@ void patchCanvasKitModule(DomHTMLScriptElement canvasKitScript) {
final Object? exportsAccessor = js_util.jsify(<String, dynamic>{
'get': allowInterop(() {
if (domDocument.currentScript == canvasKitScript) {
return js_util.callConstructor(objectConstructor, null);
return objectConstructor;
} else {
return _flutterWebCachedExports;
}
Expand All @@ -2677,7 +2677,7 @@ void patchCanvasKitModule(DomHTMLScriptElement canvasKitScript) {
final Object? moduleAccessor = js_util.jsify(<String, dynamic>{
'get': allowInterop(() {
if (domDocument.currentScript == canvasKitScript) {
return js_util.callConstructor(objectConstructor, null);
return objectConstructor;
} else {
return _flutterWebCachedModule;
}
Expand Down