Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Improved readme for impeller golden tests. #40679

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Improved readme for impeller golden tests. #40679

merged 1 commit into from
Mar 27, 2023

Conversation

gaaclarke
Copy link
Member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from dnfield March 27, 2023 21:09
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot merged commit 86e4066 into flutter:main Mar 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
86e406698 Improved readme for golden tests. (flutter/engine#40679)
49f9aa8
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
86e406698 Improved readme for golden tests. (flutter/engine#40679) (#…
4db9c50 
…123572)

Roll Flutter Engine from 8cb080365fb1 to 86e406698055 (1 revision)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 28, 2023
flutter: 86e406698 Improved readme for golden tests. (flutter/engine#…
9f64e21 
…40679) (#123572)

Commit: 4db9c50e4a73364651e224060b1769dbd677b9e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
ed2b6c6 
…0679) (flutter/flutter#123572)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
f6bed65 
…0679) (flutter/flutter#123572)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
85d0a86 
…0679) (flutter/flutter#123572)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
7e5e0c1 
…0679) (flutter/flutter#123572)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
55904b6 
…0679) (flutter/flutter#123572)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4db9c50 86e406698 Improved readme for golden tests. (flutter/engine#4…
5738dd0 
…0679) (flutter/flutter#123572)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @dnfield