Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web test reorganization #39984

Merged
merged 56 commits into from
Mar 28, 2023
Merged

Web test reorganization #39984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c13cd89
Wrote felt_config file and parsing.
eyebrowsoffire Feb 10, 2023
b60b1b4
Some suite filtering and copy artifacts step refactor.
eyebrowsoffire Feb 14, 2023
8760d77
CompileBundleStep implemented.
eyebrowsoffire Feb 16, 2023
752547d
Suites running, but assets alongside tests are not being served.
eyebrowsoffire Feb 17, 2023
1bdd442
Reduce verbosity and fix serving assets from test directory.
eyebrowsoffire Feb 17, 2023
b6e520e
All filters except file filters are implemented.
eyebrowsoffire Feb 17, 2023
e26e6a3
File filter implemented.
eyebrowsoffire Feb 17, 2023
c2d464d
Move around tests themselves.
eyebrowsoffire Feb 17, 2023
3c9c37d
Test against canvaskit_chromium.
eyebrowsoffire Feb 17, 2023
a7906e8
Added and updated documentation.
eyebrowsoffire Feb 17, 2023
b0cfad9
Started some CI stuff.
eyebrowsoffire Mar 1, 2023
78859af
Add bringup:true to the new web engine step.
eyebrowsoffire Mar 1, 2023
2dd558d
Change felt parameters.
eyebrowsoffire Mar 1, 2023
35163cf
Remove old web engine builders.
eyebrowsoffire Mar 1, 2023
d721f10
Always hard code canvaskit variants for chrome and edge.
eyebrowsoffire Mar 2, 2023
ad81ea6
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 2, 2023
c48e279
improve some error messages
mdebbar Mar 2, 2023
83f67b8
support filtering by canvaskit variant
mdebbar Mar 2, 2023
c5f60d1
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 7, 2023
1687708
Change linux_web_engine to new felt commands.
eyebrowsoffire Mar 7, 2023
d6ec4e7
Skip the legacy build path for license checks.
eyebrowsoffire Mar 8, 2023
77e0119
Update lib/web_ui/dev/steps/compile_bundle_step.dart
eyebrowsoffire Mar 8, 2023
7fcc94b
Revert weird change to README.md
eyebrowsoffire Mar 8, 2023
8294f13
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 8, 2023
581023a
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 10, 2023
28808e7
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 10, 2023
55195f0
Separate web_tests build out.
eyebrowsoffire Mar 10, 2023
dbc98f9
Copy artifacts in a generator step.
eyebrowsoffire Mar 10, 2023
0c6bf80
Do copy artifacts as part of the test run.
eyebrowsoffire Mar 10, 2023
dd3c7b9
Allow testing against wasm_profile artifacts.
eyebrowsoffire Mar 11, 2023
38dd751
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 13, 2023
f390a96
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 16, 2023
db9c9e0
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 23, 2023
1071c87
Remove duplicated build step.
eyebrowsoffire Mar 23, 2023
5f5ff75
Add new fields for the v2 tests.
eyebrowsoffire Mar 23, 2023
0cc002e
Put the test invocation into `tasks`
eyebrowsoffire Mar 23, 2023
d5a9e7a
Name the test.
eyebrowsoffire Mar 23, 2023
d84c677
Try sharding compilation and tests.
eyebrowsoffire Mar 23, 2023
bb45d11
Fix bundle filtering.
eyebrowsoffire Mar 23, 2023
ee89022
Try making copy artifacts a subbuild.
eyebrowsoffire Mar 23, 2023
164483f
The main build should be `web_tests/artifacts`
eyebrowsoffire Mar 23, 2023
c25b4da
test_bundles, not test_bundle
eyebrowsoffire Mar 24, 2023
97f9459
Generate all builder json.
eyebrowsoffire Mar 24, 2023
a8bc5c4
Specify an empty tests list.
eyebrowsoffire Mar 24, 2023
442034d
Generate the builder json again.
eyebrowsoffire Mar 24, 2023
eb1e3ec
script, not scripts.
eyebrowsoffire Mar 24, 2023
d25ca9e
Get rid of extra array layer.
eyebrowsoffire Mar 24, 2023
aed3f1b
No need for empty tests array in build steps
eyebrowsoffire Mar 24, 2023
f47bfd3
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 24, 2023
2271295
It's `script` for tests, but `scripts` for generators.
eyebrowsoffire Mar 24, 2023
d4a7f5a
Mac, not MacOS
eyebrowsoffire Mar 24, 2023
6d5fa74
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 24, 2023
4ed8d43
Yegor's comments.
eyebrowsoffire Mar 27, 2023
d66c188
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 27, 2023
ba83669
Add back screenshot logging under verbose flag.
eyebrowsoffire Mar 27, 2023
9b61f3a
Merge branch 'main' into web_test_reorganization
eyebrowsoffire Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
It's script for tests, but scripts for generators.
  • Loading branch information
@eyebrowsoffire
eyebrowsoffire committed Mar 24, 2023
commit 2271295185630aaf1f2d9535e0cc8b660056be77
60 changes: 45 additions & 15 deletions ci/builders/linux_web_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,28 @@
"parameters": [
"check-licenses"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
},
{
"name": "web engine analysis",
"parameters": [
"analyze"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
},
{
"name": "copy artifacts for web tests",
"parameters": [
"test",
"--copy-artifacts"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -76,7 +82,9 @@
"--compile",
"--bundle=dart2js-html-engine"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -97,7 +105,9 @@
"--compile",
"--bundle=dart2js-html-html"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -118,7 +128,9 @@
"--compile",
"--bundle=dart2js-html-ui"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -139,7 +151,9 @@
"--compile",
"--bundle=dart2js-canvaskit-canvaskit"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -160,7 +174,9 @@
"--compile",
"--bundle=dart2js-canvaskit-ui"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -181,7 +197,9 @@
"--compile",
"--bundle=dart2js-skwasm-skwasm_stub"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -202,7 +220,9 @@
"--compile",
"--bundle=dart2wasm-html-engine"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -223,7 +243,9 @@
"--compile",
"--bundle=dart2wasm-html-html"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -244,7 +266,9 @@
"--compile",
"--bundle=dart2wasm-html-ui"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -265,7 +289,9 @@
"--compile",
"--bundle=dart2wasm-canvaskit-canvaskit"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -286,7 +312,9 @@
"--compile",
"--bundle=dart2wasm-canvaskit-ui"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand All @@ -307,7 +335,9 @@
"--compile",
"--bundle=dart2wasm-skwasm-ui"
],
"script": "flutter/lib/web_ui/dev/felt"
"scripts": [
"flutter/lib/web_ui/dev/felt"
]
}
]
}
Expand Down
8 changes: 4 additions & 4 deletions lib/web_ui/dev/generate_builder_json.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,23 +59,23 @@ Map<String, dynamic> _getArtifactBuildStep() {
'parameters': <String>[
'check-licenses'
],
'script': 'flutter/lib/web_ui/dev/felt',
'scripts': <String>[ 'flutter/lib/web_ui/dev/felt' ],

},
<String, dynamic>{
'name': 'web engine analysis',
'parameters': <String>[
'analyze'
],
'script': 'flutter/lib/web_ui/dev/felt',
'scripts': <String>[ 'flutter/lib/web_ui/dev/felt' ],
},
<String, dynamic>{
'name': 'copy artifacts for web tests',
'parameters': <String>[
'test',
'--copy-artifacts',
],
'script': 'flutter/lib/web_ui/dev/felt',
'scripts': <String>[ 'flutter/lib/web_ui/dev/felt' ],
},
]
},
Expand All @@ -99,7 +99,7 @@ Map<String, dynamic> _getBundleBuildStep(TestBundle bundle) {
'--compile',
'--bundle=${bundle.name}',
],
'script': 'flutter/lib/web_ui/dev/felt',
'scripts': <String>[ 'flutter/lib/web_ui/dev/felt' ],
}
]
},
Expand Down