Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[lint + clang tidy] add lint check for python file changes" #39930

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 27, 2023

Reverts #39736

The actual fix was related to glob behavior in flutter/cocoon#2506.

We don't need *.py to run in both Linux Host clang-tidy and Linux Android clang-tidy, so remove the former.

Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)
thanks for identifying and landing the fix so fast!

@jmagman jmagman self-assigned this Feb 27, 2023
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 28, 2023

auto label is removed for flutter/engine, pr: 39930, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 2, 2023
@auto-submit auto-submit bot merged commit a0785fd into main Mar 2, 2023
@auto-submit auto-submit bot deleted the revert-39736-xilaizhang-lint-2 branch March 2, 2023 19:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
Revert "[lint + clang tidy] add lint check for python file changes"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants