Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make FlutterException constructor public #39817

Closed
wants to merge 1 commit into from
Closed

Make FlutterException constructor public #39817

wants to merge 1 commit into from

Conversation

xegrox
Copy link

@xegrox xegrox commented Feb 23, 2023

The default constructor access modifier in java is package-private, which restricts access outside of this package
Change the constructor to public so that others may construct their own FlutterException

20230223_20h48m21s_grim

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor

I'll follow up in the Pigeon PR, but I don't think this is the right avenue here; the documentation for this class is "Thrown to indicate that a Flutter method invocation failed on the Flutter side", and you are trying to repurpose it for the opposite.

@xegrox xegrox closed this Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants