Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[impeller] Refactored backend specific feature checks to capabilities #39598

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

iskakaushik
Copy link
Contributor

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about the setter names, but otherwise LGTM.

@iskakaushik
Copy link
Contributor Author

renaming to IDeviceCapabilities short for ImpellerDeviceCapabilities to avoid windows conflicts:

ninja -t msvc -e environment.x64 -- C:\b\s\w\ir\cache\goma\client/gomacc.exe ../../buildtools/windows-x64/clang/bin/clang-cl.exe  /nologo /showIncludes @obj/flutter/impeller/renderer/backend/gles/gles.surface_gles.obj.rsp /c ../../flutter/impeller/renderer/backend/gles/surface_gles.cc /Foobj/flutter/impeller/renderer/backend/gles/gles.surface_gles.obj /Fdobj/flutter/impeller/renderer/backend/gles/gles_cc.pdb
In file included from ../../flutter/impeller/renderer/backend/gles/surface_gles.cc:9:
../../flutter\impeller/renderer/backend/gles/context_gles.h(44,19): error: template argument for template type parameter must be a type
  std::unique_ptr<DeviceCapabilities> device_capabilities_;
                  ^~~~~~~~~~~~~~~~~~
C:\b\s\w\ir\kitchen-checkout\depot_tools\win_toolchain\vs_files\1023ce2e82\Windows Kits\10\Include\10.0.20348.0\um\wingdi.h(3946,29): note: expanded from macro 'DeviceCapabilities'
#define DeviceCapabilities  DeviceCapabilitiesW
                            ^~~~~~~~~~~~~~~~~~~
C:\b\s\w\ir\kitchen-checkout\depot_tools\win_toolchain\vs_files\1023ce2e82\VC\Tools\MSVC\14.29.30133\include\memory(3273,20): note: template parameter is declared here
    template <class, class>
                   ^
In file included from ../../flutter/impeller/renderer/backend/gles/surface_gles.cc:9:
../../flutter\impeller/renderer/backend/gles/context_gles.h(73,9): error: unknown type name 'DeviceCapabilitiesW'; did you mean 'DeviceCapabilities'?
  const DeviceCapabilities& GetDeviceCapabilities() const override;
        ^~~~~~~~~~~~~~~~~~
        DeviceCapabilities
C:\b\s\w\ir\kitchen-checkout\depot_tools\win_toolchain\vs_files\1023ce2e82\Windows Kits\10\Include\10.0.20348.0\um\wingdi.h(3946,29): note: expanded from macro 'DeviceCapabilities'
#define DeviceCapabilities  DeviceCapabilitiesW
                            ^
../../flutter\impeller/renderer/device_capabilities.h(13,7): note: 'DeviceCapabilities' declared here
class DeviceCapabilities {
      ^

We can rename later if needed.

@iskakaushik iskakaushik merged commit 3141b11 into flutter:main Feb 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2023
…120761)

* ab2dec516 Roll Skia from 8de7f68a3661 to 67a8177742e6 (4 revisions) (flutter/engine#39623)

* a7ec1e50f Remove libpng dependency in the APNG decoder (flutter/engine#39622)

* cb5393336 Add more info to malioc_diff.py output (flutter/engine#39625)

* 60c199501 Roll Dart SDK from ea59504416a8 to 22ad11262460 (2 revisions) (flutter/engine#39624)

* b1f76fbb0 [Impeller] Avoid stringstream usage in CreateUniformMemberKey (flutter/engine#39606)

* a85220d2f Fix a flake in EmbedderTest.CompositorRenderTargetsNotRecycledWhenAvoidsCacheSet (flutter/engine#39596)

* 3141b116d [impeller] Refactored backend specific feature checks to capabilities (flutter/engine#39598)

* bf667254f [impellerc] Generate GLSL output for the runtime-stage-gles target (flutter/engine#39602)

* 57e83aa16 [Impeller] Special case color filter in tiled texture. (flutter/engine#39445)

* e1325a9de Roll Skia from 67a8177742e6 to a3fe5233eb10 (9 revisions) (flutter/engine#39627)

* 9f2c4db50 Add app anatomy diagram (flutter/engine#39628)

* e8c14e436 Roll Fuchsia Linux SDK from mWwKhmxRlXNJATVmu... to A15Lg2MzGSkbj33mo... (flutter/engine#39631)

* 9bd50b706 [Impeller] read from framebuffer for advanced blends on iOS. (flutter/engine#39567)

* 66715c928 Fix build output path of the malioc core list (flutter/engine#39629)

* 727500b12 Roll Skia from a3fe5233eb10 to b7508e2f2577 (3 revisions) (flutter/engine#39634)

* f193de9cc [Impeller] Make RenderTarget::CreateOffscreen utilities have a stencil by default (flutter/engine#39636)

* 76b51e33a Roll Skia from b7508e2f2577 to 5974e36ea190 (4 revisions) (flutter/engine#39639)

* aba44ff0b Roll Dart SDK from 22ad11262460 to 1dc26efa3c4c (1 revision) (flutter/engine#39640)

* 657102f87 Roll Fuchsia Mac SDK from EFcCpAxOuQllDqP0F... to jsnm3dngrd9MveHrB... (flutter/engine#39641)

* 44e36c9c0 Roll Skia from 5974e36ea190 to 2a7644cf4bd7 (1 revision) (flutter/engine#39642)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants