Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Cherry-pick Avoid animation jank by setting FlutterViewController backgroundColor to clearColor #39436

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 6, 2023

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Feb 6, 2023

Test failures are due to flutter/flutter#120093, which hasn't been cherry-picked to the release candidate branch yet.

@jmagman jmagman changed the title Cherry-pick Ensure FlutterView's background color is not nil Cherry-pick Avoid animation jank by setting FlutterViewController backgroundColor to clearColor Feb 6, 2023
@godofredoc
Copy link
Contributor

@jonahwilliams can you please rebase this change? it will help to pass all the presubmit checks.

@godofredoc
Copy link
Contributor

@jonahwilliams can you please rebase this change? it will help to pass all the presubmit checks.

Oops sorry I meant @jmagman

@jmagman
Copy link
Member Author

jmagman commented Feb 7, 2023

can you please rebase this change? it will help to pass all the presubmit checks.

Done!

@jmagman
Copy link
Member Author

jmagman commented Feb 8, 2023

@godofredoc should I merge this or will the release team do it?

@godofredoc godofredoc merged commit f73877a into flutter:flutter-3.7-candidate.1 Feb 8, 2023
@jmagman jmagman deleted the cp-bgcolor branch February 8, 2023 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants