Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Don't rely on timings for dimension_provider unit test. #39343

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 2, 2023
@eyebrowsoffire eyebrowsoffire requested a review from ditman February 2, 2023 17:49
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing test flakiness!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2023
@auto-submit auto-submit bot merged commit 510ecfa into flutter:main Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 2, 2023
…119859)

* 510ecfa93 Don't rely on timings for dimension_provider unit test. (flutter/engine#39343)

* b1ccae745 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter/engine#39344)

* 616ecd8be [Web][HTML] Add mirrored characters support for RTL languages (flutter/engine#39162)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web test custom_element_dimensions_provider_test.dart is flaky
2 participants